Skip to content

Add tip to reload window if user has attempted to install Python in the interpreter quickpick #19431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karrtikr opened this issue Jul 8, 2022 · 6 comments · Fixed by #19446
Assignees
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link

karrtikr commented Jul 8, 2022

This will only be displayed if "Python is not installed" item has been clicked once.

image

cc/ @luabud This would mean we can remove the following text:

@karrtikr karrtikr added feature-request Request for new features or functionality needs PR area-environments Features relating to handling interpreter environments labels Jul 8, 2022
@karrtikr karrtikr added this to the July 2022 milestone Jul 8, 2022
@karrtikr karrtikr self-assigned this Jul 8, 2022
@karrtikr karrtikr changed the title Add tip to reload window in interpreters list Add tip to reload window in Interpreters list Jul 8, 2022
@luabud
Copy link
Member

luabud commented Jul 8, 2022

Amazing! Agreed, the text in the walkthrough can be removed once this is available 😊

@DonJayamanne
Copy link

Curious why anyone would need to reload vs code after installing the python extension.
From what i know, once you install it for the first time, and if you already have a Python file opened, then it will get activated automatically, meaning there's no need to reload vs code.

@karrtikr
Copy link
Author

karrtikr commented Jul 9, 2022

@DonJayamanne This is about installing Python interpreter itself, not the Python extension. A reload maybe required to discover a new python install.

@DonJayamanne
Copy link

reload maybe required to discover a new python install.

oh i thought a refresh button was added to the list (stop users can refresh three interpreter least), can't we use that, reloading feels too heavy handed. anyways, just a suggestion.

@karrtikr
Copy link
Author

karrtikr commented Jul 9, 2022

Yes, but a reload is required to refresh the environment variables like PATH, so refresh button may not always help. For eg. reload is not required to discover a new windows store install but it's required for python.org.

@karrtikr karrtikr changed the title Add tip to reload window in Interpreters list Add tip to reload window if user has attempted to install Python in the interpreter quickpick Jul 11, 2022
@karrtikr
Copy link
Author

karrtikr commented Jul 25, 2022

Verification steps:

  • Open a system with no Python installed.
  • Run Python: Select Interpreter command to see:
    image
  • Click "Python is not installed" item.
  • Run Python: Select Interpreter command again:
    image
  • This time the tip to reload window appears.

@karrtikr karrtikr added the verification-needed Verification of issue is requested label Jul 25, 2022
@andreamah andreamah added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
4 participants