Skip to content

Line feeds should be forced to CRLF in test messages #17111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
connor4312 opened this issue Aug 24, 2021 · 0 comments · Fixed by #17373
Closed

Line feeds should be forced to CRLF in test messages #17111

connor4312 opened this issue Aug 24, 2021 · 0 comments · Fixed by #17373
Labels
area-testing bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority partner ask
Milestone
August Recovery 2

Comments

@connor4312
Copy link
Member

Testing #17040

image

It looks like we should force CRLF here. str.replace(/(?<!\r)\n/gm, '\r\n') works
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 24, 2021
@karthiknadig karthiknadig removed their assignment Aug 24, 2021
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug needs PR important Issue identified as high-priority partner ask area-testing and removed triage-needed Needs assignment to the proper sub-team labels Aug 24, 2021
This was referenced Sep 10, 2021
Open
Merged
@karthiknadig karthiknadig added this to the August Recovery 2 milestone Sep 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-testing bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority partner ask
Projects
None yet
Milestone
August Recovery 2
Development

Successfully merging a pull request may close this issue.

Improve display of lines in test output. karthiknadig/vscode-python
2 participants
@connor4312 @karthiknadig