File tree 2 files changed +4
-2
lines changed
src/client/pythonEnvironments/base/locators/composite 2 files changed +4
-2
lines changed Original file line number Diff line number Diff line change @@ -55,6 +55,8 @@ async function* iterEnvsIterator(
55
55
if ( isProgressEvent ( event ) ) {
56
56
if ( event . stage === ProgressReportStage . discoveryFinished ) {
57
57
state . done = true ;
58
+ // For super slow locators such as Windows registry, we expect updates even after discovery
59
+ // is "officially" finished, hence do not dispose listeners.
58
60
// listener.dispose();
59
61
} else {
60
62
didUpdate . fire ( event ) ;
@@ -122,7 +124,6 @@ function checkIfFinishedAndNotify(
122
124
) {
123
125
if ( state . done && state . pending === 0 ) {
124
126
didUpdate . fire ( { stage : ProgressReportStage . discoveryFinished } ) ;
125
- // didUpdate.dispose();
126
127
traceVerbose ( `Finished with environment reducer` ) ;
127
128
state . done = false ; // No need to notify again.
128
129
}
Original file line number Diff line number Diff line change @@ -87,6 +87,8 @@ export class PythonEnvsResolver implements IResolvingLocator {
87
87
if ( event . stage === ProgressReportStage . discoveryFinished ) {
88
88
didUpdate . fire ( { stage : ProgressReportStage . allPathsDiscovered } ) ;
89
89
state . done = true ;
90
+ // For super slow locators such as Windows registry, we expect updates even after discovery
91
+ // is "officially" finished, hence do not dispose listeners.
90
92
// listener.dispose();
91
93
} else {
92
94
didUpdate . fire ( event ) ;
@@ -172,7 +174,6 @@ function checkIfFinishedAndNotify(
172
174
) {
173
175
if ( state . done && state . pending === 0 ) {
174
176
didUpdate . fire ( { stage : ProgressReportStage . discoveryFinished } ) ;
175
- // didUpdate.dispose();
176
177
traceVerbose ( `Finished with environment resolver` ) ;
177
178
}
178
179
}
You can’t perform that action at this time.
0 commit comments