Bind function to class instance in middleware (#9109)

Mikhail Arkhipov · web-flow · commit 7167439a04ae · 2019-12-16T09:49:21.000-08:00
* Bind function to class

* Add news
diff --git a/news/2 Fixes/9096.md b/news/2 Fixes/9096.md
@@ -0,0 +1 @@
+Fix issue that prevented language server diagnostics from being published.
diff --git a/src/client/activation/languageServer/languageClientMiddleware.ts b/src/client/activation/languageServer/languageClientMiddleware.ts
@@ -58,6 +58,7 @@ export class LanguageClientMiddleware implements Middleware {
     private connected = false; // Default to not forwarding to VS code.
 
     public constructor(private readonly surveyBanner: IPythonExtensionBanner) {
+        this.handleDiagnostics = this.handleDiagnostics.bind(this); // VS Code calls function without context.
     }
 
     public connect() {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix issue that prevented language server diagnostics from being published.`
Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ export class LanguageClientMiddleware implements Middleware {`
`58`	`58`	`private connected = false; // Default to not forwarding to VS code.`
`59`	`59`
`60`	`60`	`public constructor(private readonly surveyBanner: IPythonExtensionBanner) {`
	`61`	`+ this.handleDiagnostics = this.handleDiagnostics.bind(this); // VS Code calls function without context.`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`public connect() {`