From aedd81da3b054d8a7a4b53cc6c4a68c8baaa170f Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Fri, 9 May 2025 13:01:19 -0700 Subject: [PATCH 1/3] Locked the double quote in path.with.spaces. --- Extension/src/LanguageServer/configurations.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Extension/src/LanguageServer/configurations.ts b/Extension/src/LanguageServer/configurations.ts index 406ae4369..cabdca929 100644 --- a/Extension/src/LanguageServer/configurations.ts +++ b/Extension/src/LanguageServer/configurations.ts @@ -1654,7 +1654,8 @@ export class CppProperties { const compilerPathErrors: string[] = []; if (compilerPathMayNeedQuotes && !pathExists) { - compilerPathErrors.push(localize("path.with.spaces", 'Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes (").')); + compilerPathErrors.push(localize({ key: "path.with.spaces", comment: ["{Locked=\"\"\"}"] }, + 'Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes (").')); telemetry.CompilerPathMissingQuotes = 1; } From 9adc6124e41e6ccf6bdb651085781b631449b66e Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Mon, 12 May 2025 13:45:12 -0700 Subject: [PATCH 2/3] Alternative fix. --- Extension/src/LanguageServer/configurations.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Extension/src/LanguageServer/configurations.ts b/Extension/src/LanguageServer/configurations.ts index cabdca929..941599622 100644 --- a/Extension/src/LanguageServer/configurations.ts +++ b/Extension/src/LanguageServer/configurations.ts @@ -1654,8 +1654,8 @@ export class CppProperties { const compilerPathErrors: string[] = []; if (compilerPathMayNeedQuotes && !pathExists) { - compilerPathErrors.push(localize({ key: "path.with.spaces", comment: ["{Locked=\"\"\"}"] }, - 'Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes (").')); + compilerPathErrors.push(localize({ key: "path.with.spaces", comment: ["{Locked=\"{0}\" The {0} is a double quote character \", and should be located next to the translation for \"double quotes\".}"] }, + "Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes ({0}).", '"')); telemetry.CompilerPathMissingQuotes = 1; } From f726a12e1db6c73e7532b606958a4bf7d3784ab6 Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Mon, 12 May 2025 13:46:35 -0700 Subject: [PATCH 3/3] Fix locked comment. --- Extension/src/LanguageServer/configurations.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Extension/src/LanguageServer/configurations.ts b/Extension/src/LanguageServer/configurations.ts index 941599622..91268b499 100644 --- a/Extension/src/LanguageServer/configurations.ts +++ b/Extension/src/LanguageServer/configurations.ts @@ -1654,7 +1654,7 @@ export class CppProperties { const compilerPathErrors: string[] = []; if (compilerPathMayNeedQuotes && !pathExists) { - compilerPathErrors.push(localize({ key: "path.with.spaces", comment: ["{Locked=\"{0}\" The {0} is a double quote character \", and should be located next to the translation for \"double quotes\".}"] }, + compilerPathErrors.push(localize({ key: "path.with.spaces", comment: ["{Locked=\"{0}\"} The {0} is a double quote character \", and should be located next to the translation for \"double quotes\"."] }, "Compiler path with spaces could not be found. If this was intended to include compiler arguments, surround the compiler path with double quotes ({0}).", '"')); telemetry.CompilerPathMissingQuotes = 1; }