Merge branch 'main' into enable-gh-azdo-plugin

Author: nohwnd

Directory.Packages.props

@@ -29,8 +29,8 @@
   </PropertyGroup>
   <PropertyGroup Label="Test dependencies">
     <MicrosoftCodeAnalysisAnalyzerTestingVersion>1.1.3-beta1.24423.1</MicrosoftCodeAnalysisAnalyzerTestingVersion>
-    <MSTestVersion>3.9.0-preview.25225.2</MSTestVersion>
-    <MicrosoftTestingPlatformVersion>1.7.0-preview.25225.2</MicrosoftTestingPlatformVersion>
+    <MSTestVersion>3.9.0-preview.25226.1</MSTestVersion>
+    <MicrosoftTestingPlatformVersion>1.7.0-preview.25226.1</MicrosoftTestingPlatformVersion>
   </PropertyGroup>
   <ItemGroup Label="Analyzers">
     <PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="$(MicrosoftCodeAnalysisBannedApiAnalyzersVersion)" />

src/Platform/Microsoft.Testing.Extensions.Retry/RetryDataConsumer.cs

@@ -41,7 +41,12 @@ public RetryDataConsumer(IServiceProvider serviceProvider)
     public async Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationToken cancellationToken)
     {
         var testNodeUpdateMessage = (TestNodeUpdateMessage)value;
-        TestNodeStateProperty nodeState = testNodeUpdateMessage.TestNode.Properties.Single<TestNodeStateProperty>();
+        TestNodeStateProperty? nodeState = testNodeUpdateMessage.TestNode.Properties.SingleOrDefault<TestNodeStateProperty>();
+        if (nodeState is null)
+        {
+            return;
+        }
+
         if (Array.IndexOf(TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties, nodeState.GetType()) != -1)
         {
             ApplicationStateGuard.Ensure(_retryFailedTestsLifecycleCallbacks is not null);

src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxDataConsumer.cs

@@ -115,7 +115,12 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
             switch (value)
             {
                 case TestNodeUpdateMessage nodeChangedMessage:
-                    TestNodeStateProperty nodeState = nodeChangedMessage.TestNode.Properties.Single<TestNodeStateProperty>();
+                    TestNodeStateProperty? nodeState = nodeChangedMessage.TestNode.Properties.SingleOrDefault<TestNodeStateProperty>();
+                    if (nodeState is null)
+                    {
+                        return Task.CompletedTask;
+                    }
+
                     if (nodeState is PassedTestNodeStateProperty)
                     {
                         _tests.Add(nodeChangedMessage);

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs

@@ -63,7 +63,12 @@ public async Task ConsumeAsync(IDataProducer dataProducer, IData value, Cancella
         RoslynDebug.Assert(_maxFailedTests is not null);
         RoslynDebug.Assert(_capability is not null);
 
-        TestNodeStateProperty testNodeStateProperty = node.TestNode.Properties.Single<TestNodeStateProperty>();
+        TestNodeStateProperty? testNodeStateProperty = node.TestNode.Properties.SingleOrDefault<TestNodeStateProperty>();
+        if (testNodeStateProperty is null)
+        {
+            return;
+        }
+
         if (TestNodePropertiesCategories.WellKnownTestNodeTestRunOutcomeFailedProperties.Any(t => t == testNodeStateProperty.GetType()) &&
             ++_failCount >= _maxFailedTests.Value &&
             // If already triggered, don't do it again.

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/DotnetTestDataConsumer.cs

@@ -47,7 +47,11 @@ public async Task ConsumeAsync(IDataProducer dataProducer, IData value, Cancella
         {
             case TestNodeUpdateMessage testNodeUpdateMessage:
 
-                TestNodeDetails testNodeDetails = GetTestNodeDetails(testNodeUpdateMessage);
+                TestNodeDetails? testNodeDetails = GetTestNodeDetails(testNodeUpdateMessage);
+                if (testNodeDetails is null)
+                {
+                    return;
+                }
 
                 switch (testNodeDetails.State)
                 {
@@ -172,13 +176,18 @@ public async Task ConsumeAsync(IDataProducer dataProducer, IData value, Cancella
         }
     }
 
-    private static TestNodeDetails GetTestNodeDetails(TestNodeUpdateMessage testNodeUpdateMessage)
+    private static TestNodeDetails? GetTestNodeDetails(TestNodeUpdateMessage testNodeUpdateMessage)
     {
         byte? state = null;
         long? duration = null;
         string? reason = string.Empty;
         ExceptionMessage[]? exceptions = null;
-        TestNodeStateProperty nodeState = testNodeUpdateMessage.TestNode.Properties.Single<TestNodeStateProperty>();
+        TestNodeStateProperty? nodeState = testNodeUpdateMessage.TestNode.Properties.SingleOrDefault<TestNodeStateProperty>();
+        if (nodeState is null)
+        {
+            return null;
+        }
+
         string? standardOutput = testNodeUpdateMessage.TestNode.Properties.SingleOrDefault<StandardOutputProperty>()?.StandardOutput;
         string? standardError = testNodeUpdateMessage.TestNode.Properties.SingleOrDefault<StandardErrorProperty>()?.StandardError;