Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Maintenance of pandas type stubs #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dr-Irv opened this issue Dec 9, 2020 · 8 comments
Closed

Maintenance of pandas type stubs #35

Dr-Irv opened this issue Dec 9, 2020 · 8 comments

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Dec 9, 2020

The pandas team has an open issue with regards to type stubs: pandas-dev/pandas#28142

We'd like to have some discussion with the key developers (@jakebailey ? @gramster ? others ?) of the pandas type stubs to determine a best way forward for upkeep of these type stubs. I brought this up at our December, 2020, monthly core developers meeting.

Might be best for you guys to contribute over there in that pandas issue.

Thanks!

@gramster
Copy link
Member

gramster commented Jan 5, 2021

Hi Irv, we'd be very interested in having this discussion; what forum do you suggest?

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 5, 2021

Hi Irv, we'd be very interested in having this discussion; what forum do you suggest?

Thanks for commenting on the pandas issue. I will also bring it up with the core team as we may want to do a deeper discussion in our next core dev meeting (which I believe is on 1/13/2021).

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 6, 2021

@gramster @erictraut Info on our monthly dev meeting can be found here: https://pandas.pydata.org/docs/development/meeting.html

It would be great if you could attend the next one on 1/13/2021 at 1PM Eastern time, as we'd like to have a discussion with you on how to move forward. Thanks!

@gvanrossum
Copy link

I'd like to attend -- is that okay? I might know a thing or two about stubs (though not necessarily about the ins and outs of how Pylance and Pyright use them -- the expert there would be @erictraut).

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 6, 2021

@gvanrossum absolutely! Our pandas dev meetings are open to all. When I get more info, I will post here.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 12, 2021

@gramster @erictraut @gvanrossum Info on tomorrow's dev meeting can be found here:
pandas-dev/pandas#39125

@gramster
Copy link
Member

gramster commented Feb 4, 2022

I think we have a rough plan of action:

  • add tests to the stubs to improve the quality and avoid regressions. The adding of initial tests has been done (b19436a) although there is work to be done to pass them and we'll likely want more;
  • following that, we can start upstreaming some of the type annotations from here into pandas; my hope is that we can do that on a file-by-file basis, and as we complete each file, we can remove it from here and start regenerating the stub from the pandas source. I still need to add the tooling to do the latter but will do that once we get to the initial set of upstream commits.

@gramster
Copy link
Member

gramster commented Feb 4, 2022

Moving this to discussions.

@microsoft microsoft locked and limited conversation to collaborators Feb 4, 2022
@gramster gramster converted this issue into discussion #147 Feb 4, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants