Skip to content

Correctness of pandas stubs using tests from pandas-stubs #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dr-Irv opened this issue Jan 17, 2022 · 7 comments
Closed

Correctness of pandas stubs using tests from pandas-stubs #125

Dr-Irv opened this issue Jan 17, 2022 · 7 comments

Comments

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jan 17, 2022

From discussion at pandas typing meeting on 1/7/2022, and follow up issue here:
pandas-dev/pandas#45253

Using the test snippets from the pandas-stubs project (https://github.com/VirtusLab/pandas-stubs), with the mypy settings from the pandas project, there are 119 errors. See pandas-dev/pandas#45253 (comment)

Should those errors get fixed here as part of this project first?

Would like advice from @jakebailey and @gramster

@jakebailey
Copy link
Member

I don't work on Python anymore (officially), so I can't speak for the team, but my guess is that fixing things here would be immediately beneficial for the current users (but someone from our side would have to get them merged and backported).

@judej

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 18, 2022

@jakebailey I think you've been the one who has been approving my PR's here, so is there now someone else responsible?

@jakebailey
Copy link
Member

I'm not personally aware (I'm not on the same team anymore), but @judej or @gramster would know. I had all of the repos going to my inbox to not miss anything (then, backported), so someone would need to ensure this repo's changes get picked up.

@gramster
Copy link
Member

I'll take a look at how many of these I can address; I will have some time tomorrow.

@gramster
Copy link
Member

gramster commented Feb 4, 2022

I have added these now with PR b19436a; still need to work through a number of them.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Feb 4, 2022

So are the CI failures on my latest PRs that I am getting related to the work you need to do to fix them up?

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Feb 12, 2022

as of #160 tests are integrated and working. @gramster to confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants