-
Notifications
You must be signed in to change notification settings - Fork 102
Correctness of pandas stubs using tests from pandas-stubs #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't work on Python anymore (officially), so I can't speak for the team, but my guess is that fixing things here would be immediately beneficial for the current users (but someone from our side would have to get them merged and backported). |
@jakebailey I think you've been the one who has been approving my PR's here, so is there now someone else responsible? |
I'll take a look at how many of these I can address; I will have some time tomorrow. |
I have added these now with PR b19436a; still need to work through a number of them. |
So are the CI failures on my latest PRs that I am getting related to the work you need to do to fix them up? |
From discussion at pandas typing meeting on 1/7/2022, and follow up issue here:
pandas-dev/pandas#45253
Using the test snippets from the pandas-stubs project (https://github.com/VirtusLab/pandas-stubs), with the
mypy
settings from the pandas project, there are 119 errors. See pandas-dev/pandas#45253 (comment)Should those errors get fixed here as part of this project first?
Would like advice from @jakebailey and @gramster
The text was updated successfully, but these errors were encountered: