[BUG] 1.29.1 browserserver + page.goto = net::ERR_SOCKS_CONNECTION_FAILED

[dominikg]

Context:

• Playwright Version: 1.29.1
• Operating System: linux
• Node.js version: node18
• Browser:chromium

Code Snippet

sorry, no easy code snippet for now as this involves a browserserver, i'll try to reduce a testcase in the coming days but maybe you have an idea about it even with this.

reproduction: https://github.com/dominikg/pwsock

originally discovered in vite-plugin-svelte repo:

git clone git@github.com:sveltejs/vite-plugin-svelte.git
cd vite-plugin-svelte
pnpm i
pnpm test:build  #passes with playwright-core@1.28.1
pnpm i -Dw  playwright-core@1.29.1
pnpm test:build # fails with errors during setup, initial page.goto can't use socks?

Describe the bug

page.goto fails to connect for each test

page.goto: net::ERR_SOCKS_CONNECTION_FAILED at http://localhost:5510/

some also log

(node:81641) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 socksRequested listeners added to [SocksProxy]. Use emitter.setMaxListeners() to increase limit

links:
create browserserver
page.goto call

cc @dgozman you've been working on socks related features lately

[dgozman]

Hmm... I cannot repro this locally. After following the repro steps and updating to 1.29.1, I can repro the EventEmitter warning, but everything else works as expected, similar output as when using 1.28.1.

CLI Building entry: src/index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v6.5.0
CLI Target: es2020
ESM Build start
ESM dist/index.js 71.17 KB
ESM ⚡️ Build success in 22ms
building packages done
preparations done
Starting playwright server ...
Playwright server running
storing wsEndpoint in /var/folders/bw/t9s7jpk10q7bgqv3qnh2x22m0000gn/T/vitest_playwright_global_setup
clearing previous test artifacts
vitest global setup done

 RUN  v0.25.7 <redacted>/vite-plugin-svelte

stdout | unknown test
Ignore the obsolete snapshot warnings for ssrLoadModule snapshots from vitest during test:build, they are used in test:serve

···································----·-------·***
(node:20853) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 socksRequested listeners added to [SocksProxy]. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)
(node:20853) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 socksData listeners added to [SocksProxy]. Use emitter.setMaxListeners() to increase limit
···································----·-------··················

  Snapshots  11 obsolete
             ↳ packages/e2e-tests/import-queries/__tests__/import-queries.spec.ts
               · direct > Dummy.svelte?direct&svelte&type=script&sourcemap&lang.js 1
               · direct > Dummy.svelte?direct&svelte&type=style&sourcemap&lang.css 1
               · raw > mixed exports > Dummy.svelte?raw&svelte&type=all 1
               · raw > mixed exports > Dummy.svelte?raw&svelte&type=preprocessed 1
               · raw > mixed exports > Dummy.svelte?raw&svelte&type=script 1
               · raw > mixed exports > Dummy.svelte?raw&svelte&type=style 1
               · ssrLoadModule > ?raw 1
               · ssrLoadModule > ?raw&svelte&type=preprocessed 1
               · ssrLoadModule > ?raw&svelte&type=script 1
               · ssrLoadModule > ?raw&svelte&type=script&compilerOptions={"customElement":true} 1
               · ssrLoadModule > ?raw&svelte&type=style 1

 Test Files  19 passed (19)
      Tests  54 passed | 11 skipped (65)
   Start at  15:12:52
   Duration  16.73s (transform 228ms, setup 3.32s, collect 506ms, tests 39.00s)

Could it be that you launchServer with one playwright version, but connect with another?

[dominikg]

this is one consecutive terminal session, directly done on clean main branch of vite-plugin-svelte

# test result from 1.28.1
 Test Files  19 passed (19)
      Tests  100 passed | 1 skipped (101)
   Start at  00:27:29
   Duration  9.84s (transform 199ms, setup 2.86s, collect 568ms, tests 35.93s)

on  main [$] via  v18.11.0 took 28s 
# change to 1.29.1
vite-plugin-svelte ❯ pnpm i -Dw playwright-core@1.29.1
Packages: +1 -1
+-
Progress: resolved 518, reused 475, downloaded 0, added 0, done

devDependencies:
- playwright-core 1.28.1
+ playwright-core 1.29.1

The integrity of 3827 files was checked. This might have caused installation to take longer.
Done in 1.3s
on  main [$!] via  v18.11.0 
# run test again
vite-plugin-svelte ❯ pnpm test:build

> vite-plugin-svelte-monorepo@ test:build /home/dominikg/develop/sveltejs/vite-plugin-svelte
> cross-env TEST_BUILD=1 vitest run -c vitest.config.e2e.ts


preparing non ci env...
syncing node_modules
syncing node_modules done
building packages

> vite-plugin-svelte-monorepo@ build:ci /home/dominikg/develop/sveltejs/vite-plugin-svelte
> pnpm --dir packages/vite-plugin-svelte build:ci


> @sveltejs/vite-plugin-svelte@2.0.2 build:ci /home/dominikg/develop/sveltejs/vite-plugin-svelte/packages/vite-plugin-svelte
> rimraf dist && tsup-node src/index.ts --format esm

CLI Building entry: src/index.ts
CLI Using tsconfig: tsconfig.json
CLI tsup v6.5.0
CLI Target: es2020
ESM Build start
ESM dist/index.js 71.17 KB
ESM ⚡️ Build success in 23ms
building packages done
preparations done
Starting playwright server ...
Playwright server running
storing wsEndpoint in /tmp/vitest_playwright_global_setup
clearing previous test artifacts
vitest global setup done

 RUN  v0.25.7 /home/dominikg/develop/sveltejs/vite-plugin-svelte

stderr | unknown test
beforeAll failed for undefined. page.goto: net::ERR_SOCKS_CONNECTION_FAILED at http://localhost:5508/
=========================== logs ===========================
navigating to "http://localhost:5508/", waiting until "load"
============================================================

playwright-core is a devDependency in the pnpm monorepo root and only this single version is used.

vite-plugin-svelte ❯ npx envinfo --preset playwright --markdown

## System:
 - OS: Linux 5.19 Manjaro Linux
 - Memory: 57.19 GB / 62.21 GB
 - Container: Yes
## Binaries:
 - Node: 18.11.0 - ~/.local/share/pnpm/node
 - Yarn: 1.22.19 - ~/.local/share/pnpm/yarn
 - npm: 8.19.2 - ~/.local/share/pnpm/npm
## Languages:
 - Bash: 5.1.16 - /usr/bin/bash
## npmPackages:
 - playwright-core: ^1.29.1 => 1.29.1 

on  main [$!] via  v18.11.0 took 2s 
vite-plugin-svelte ❯ pnpm -r why playwright-core
Legend: production dependency, optional only, dev only

vite-plugin-svelte-monorepo /home/dominikg/develop/sveltejs/vite-plugin-svelte

devDependencies:
playwright-core 1.29.1

[dgozman]

@dominikg Do you have anything in env that could be related to playwright?

env | grep PLAYWRIGHT
env | grep PW   

[dominikg]

nope, no playwright specific env.

here is a minimal reproduction. https://github.com/dominikg/pwsock

note that the same error seems to happen when vite dev isn't executed to start the server.
Is it possible that goto doesn't work for localhost when the page is retrieved from a browserserver?

[dominikg]

output of running the test in the repro on my system:

> node index.js

trying page.goto with https://playwright.dev
SUCCESS
starting vite dev server on http://localhost:5173
(node:25355) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
fetched http://localhost:5173
 <html>
<head>
  <script type="module" src="/@vite/client"></script>

</head>
<body>
<h1>test</h1>
</body>
</html>
trying page.goto with http://localhost:5173
ERROR page.goto: net::ERR_SOCKS_CONNECTION_FAILED at http://localhost:5173/
=========================== logs ===========================
navigating to "http://localhost:5173/", waiting until "load"
============================================================
    at file:///home/dominikg/develop/reproductions/pwsock/index.js:39:16 {
  name: 'Error'
}

[dominikg]

pushed a solo update of playwright to vite-plugin-svelte to see it fail in github ci to rule out any involvement of my local system: https://github.com/sveltejs/vite-plugin-svelte/actions/runs/3762320508/jobs/6394913746

it looks like it's failing on node18 only, so this might be related to the changes in network resolution in node17+ where ipv6 adresses are returned first?