[webgpu] Get data with GetByOffset() in gemm_utils.cc
#26679
+49
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@qjia7 PTAL, thanks! |
qjia7
previously approved these changes
Dec 1, 2025
fs-eire
reviewed
Dec 1, 2025
Jiawei-Shao
changed the title
GetByOffset() in gemm_utils.ccGetByOffset() in gemm_utils.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get data from
biasandoutputwithGetByOffset()instead of direct access to the array ingemm_utils.ccMotivation and Context
Because when the input
biasor outputoutputis very large, bothbiasandoutputmay be split into multiple buffers, we must query the data frombiasandoutputwithGetByOffset()orGetByIndices()which implement the logic to get the correct split buffer.