FEAT: Linux SUSE Support #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for SUSE and openSUSE Linux distributions to the mssql-python project. The changes update platform detection logic, driver path selection, and documentation to properly handle these distributions alongside existing supported platforms.
- Updated Linux distribution detection to recognize SUSE/openSUSE via system files
- Modified driver path selection logic in both Python and C++ code to include SUSE platform
- Enhanced documentation to include SUSE installation instructions and directory structure
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_000_dependencies.py | Updated Linux distribution detection to recognize SUSE and changed default from "debian_ubuntu" to "ubuntu" |
| mssql_python/pybind/ddbc_bindings.cpp | Added SUSE detection logic in C++ driver path selection function |
| mssql_python/pybind/README.md | Expanded documentation to include SUSE and Alpine directory structures and required libraries |
| README.md | Added SUSE installation instructions and updated supported platforms list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
pr-size: small
github-actions
bot
added
pr-size: small
sumitmsft
approved these changes
Aug 29, 2025
gargsaumya
approved these changes
Aug 29, 2025
github-actions
bot
added
pr-size: small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request adds support for SUSE and openSUSE Linux distributions to the project, updating both documentation and code to correctly detect and handle these platforms. It also clarifies and expands the supported platforms list, and ensures the correct driver paths are selected for SUSE in both C++ and Python code.
Platform support and documentation updates:
README.md, removing the previous note about pending SUSE support.mssql_python/pybind/README.mdto include SUSE and Alpine builds for both x86_64 and ARM64 architectures, and listed required libraries for these platforms. [1] [2]Driver path selection logic:
GetDriverPathCppinddbc_bindings.cppto detect SUSE/openSUSE via/etc/SuSE-releaseor/etc/SUSE-brandand select the correct driver path.test_000_dependencies.pyto recognize SUSE/openSUSE and assign the appropriate driver path, with clearer default handling for other distributions. [1] [2]