resolved comments

Author: gargsaumya

mssql_python/pybind/CMakeLists.txt

@@ -272,7 +272,7 @@ target_compile_definitions(ddbc_bindings PRIVATE
 
 # Add warning level flags for MSVC
 if(MSVC)
-    target_compile_options(ddbc_bindings PRIVATE /W4 )
+    target_compile_options(ddbc_bindings PRIVATE /W4 /WX)
 endif()
 
 # Add macOS-specific string conversion fix

mssql_python/pybind/ddbc_bindings.cpp

@@ -1875,11 +1875,15 @@ SQLRETURN SQLGetData_wrap(SqlHandlePtr StatementHandle, SQLUSMALLINT colCount, p
                             row.append(py::none());
                         } else if (dataLen == 0) {
                             row.append(py::str(""));
-                        } else {
-                            assert(dataLen == SQL_NO_TOTAL);
+                        } else if (dataLen == SQL_NO_TOTAL) {
                             LOG("SQLGetData couldn't determine the length of the data. "
-                                "Returning NULL value instead. Column ID - {}", i);
+                                "Returning NULL value instead. Column ID - {}, Data Type - {}", i, dataType);
                             row.append(py::none());
+                        } else if (dataLen < 0) {
+                            LOG("SQLGetData returned an unexpected negative data length. "
+                                "Raising exception. Column ID - {}, Data Type - {}, Data Length - {}",
+                                i, dataType, dataLen);
+                            ThrowStdException("SQLGetData returned an unexpected negative data length");
                         }
                     } else {
                         LOG("Error retrieving data for column - {}, data type - {}, SQLGetData return "

tests/test_004_cursor.py

@@ -5307,6 +5307,8 @@ def test_empty_string_chunk(cursor, db_connection):
 
 
 def test_varcharmax_short(cursor, db_connection):
+    """Test inserting and retrieving a small string well below any size thresholds.
+    # Verifies basic functionality for VARCHAR(MAX) with typical input size."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")
@@ -5323,6 +5325,9 @@ def test_varcharmax_short(cursor, db_connection):
 
 
 def test_varcharmax_boundary(cursor, db_connection):
+    """Test inserting and retrieving a string at the boundary size (8000 characters),
+    which is the largest size supported without switching to streaming or large object handling.
+    Ensures proper handling at this edge case."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")
@@ -5339,6 +5344,9 @@ def test_varcharmax_boundary(cursor, db_connection):
 
 
 def test_varcharmax_streaming(cursor, db_connection):
+    """Test inserting and retrieving a string just above the boundary size (8100 characters),
+    which requires streaming mechanisms to handle data efficiently.
+    Validates that larger data triggers correct processing without truncation."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")
@@ -5355,6 +5363,8 @@ def test_varcharmax_streaming(cursor, db_connection):
 
 
 def test_varcharmax_large(cursor, db_connection):
+    """Test inserting and retrieving a very large string (100,000 characters),
+    which is well beyond typical sizes and ensures that the system can handle large VARCHAR(MAX) values."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")
@@ -5371,6 +5381,7 @@ def test_varcharmax_large(cursor, db_connection):
 
 
 def test_varcharmax_empty_string(cursor, db_connection):
+    """Test inserting and retrieving an empty string to verify correct handling of zero-length data."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")
@@ -5386,6 +5397,7 @@ def test_varcharmax_empty_string(cursor, db_connection):
 
 
 def test_varcharmax_null(cursor, db_connection):
+    """Test inserting and retrieving a NULL value to ensure proper handling of SQL NULLs."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")
@@ -5401,6 +5413,8 @@ def test_varcharmax_null(cursor, db_connection):
 
 
 def test_varcharmax_transaction_rollback(cursor, db_connection):
+    """Test that inserting a large VARCHAR(MAX) within a transaction that is rolled back
+    does not persist the data, ensuring transactional integrity."""
     try:
         cursor.execute("DROP TABLE IF EXISTS #pytest_varcharmax")
         cursor.execute("CREATE TABLE #pytest_varcharmax (col VARCHAR(MAX))")