From 3e292497081700c05b4241ce3eacd107997a2de6 Mon Sep 17 00:00:00 2001 From: Miroslav Stastny Date: Fri, 17 Jan 2020 12:53:28 +0100 Subject: [PATCH 1/2] perf: store perf bundle and results to CI artifacts --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 2dc8472c59..48794f1c58 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -105,8 +105,8 @@ jobs: yarn danger ci fi - store_artifacts: - path: dist/artifacts - destination: artifacts + path: packages/perf-test/dist + destination: artifacts/perf - run: name: Publish npm package (master only) command: | From 01bb97991bee1c6a8c2049e8a36e41214eeedef4 Mon Sep 17 00:00:00 2001 From: Miroslav Stastny Date: Fri, 17 Jan 2020 13:18:57 +0100 Subject: [PATCH 2/2] do not store any artifacts in danger --- build/dangerjs/checkPerfRegressions.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/build/dangerjs/checkPerfRegressions.ts b/build/dangerjs/checkPerfRegressions.ts index 3ce49aa491..a21a4488d2 100644 --- a/build/dangerjs/checkPerfRegressions.ts +++ b/build/dangerjs/checkPerfRegressions.ts @@ -1,5 +1,4 @@ import * as _ from 'lodash' -import * as fs from 'fs-extra' import * as path from 'path' import { DangerJS } from './types' @@ -43,15 +42,6 @@ function fluentFabricComparision(danger, markdown, warn) { }, ) - fs.mkdirpSync(config.paths.ciArtifacts('perf')) - - _.forEach(results, value => { - fs.copyFileSync( - value.fluentFlamegraphFile, - config.paths.ciArtifacts('perf', path.basename(value.fluentFlamegraphFile)), - ) - }) - const getStatus = fluentToFabric => fluentToFabric > 1 ? '🔧' : fluentToFabric >= 0.7 ? '🎯' : '🦄'