style(eslint): enable spaced-comment, @typescript-eslint/no-unused-vars (#1261)

* fix "spaced-comment"

* fix "@typescript-eslint/no-unused-vars"

* fix "no-shadow"

* reenable no-shadow

* remove unused import

Author: layershifter

build/gulp/plugins/gulp-component-menu-behaviors.ts

@@ -20,8 +20,8 @@ type BehaviorMenuItem = {
 }
 
 const getTextFromCommentToken = (commentTokens, tokenTitle): string => {
-  const token = commentTokens.find(token => token.title === tokenTitle)
-  return token ? token.description : ''
+  const resultToken = commentTokens.find(token => token.title === tokenTitle)
+  return resultToken ? resultToken.description : ''
 }
 
 export default () => {

build/gulp/tasks/docs.ts

@@ -25,10 +25,10 @@ const { paths } = config
 const g = require('gulp-load-plugins')()
 const { colors, log } = g.util
 
-const handleWatchChange = path => log(`File ${path} was changed, running tasks...`)
-const handleWatchUnlink = (group, path) => {
-  log(`File ${path} was deleted, running tasks...`)
-  remember.forget(group, path)
+const handleWatchChange = changedPath => log(`File ${changedPath} was changed, running tasks...`)
+const handleWatchUnlink = (group, changedPath) => {
+  log(`File ${changedPath} was deleted, running tasks...`)
+  remember.forget(group, changedPath)
 }
 
 // ----------------------------------------
@@ -227,7 +227,7 @@ task('watch:docs', cb => {
   // rebuild example menus
   watch(examplesIndexSrc, series('build:docs:example-menu'))
     .on('change', handleWatchChange)
-    .on('unlink', path => handleWatchUnlink('example-menu', path))
+    .on('unlink', changedPath => handleWatchUnlink('example-menu', changedPath))
 
   watch(examplesSrc, series('build:docs:example-sources'))
     .on('change', handleWatchChange)
@@ -244,7 +244,7 @@ task('watch:docs', cb => {
 
   watch(behaviorSrc, series('build:docs:component-menu-behaviors'))
     .on('change', handleWatchChange)
-    .on('unlink', path => handleWatchUnlink('component-menu-behaviors', path))
+    .on('unlink', changedPath => handleWatchUnlink('component-menu-behaviors', changedPath))
 
   // rebuild images
   watch(`${config.paths.docsSrc()}/**/*.{png,jpg,gif}`, series('build:docs:images')).on(

build/gulp/tasks/perf.ts

@@ -72,9 +72,9 @@ const normalizeMeasures = (measures: ProfilerMeasureCycle[]): NormalizedMeasures
     {},
   )
 
-  return _.mapValues(perExampleMeasures, (measures: ProfilerMeasure[]) => ({
-    actualTime: reduceMeasures(measures, 'actualTime'),
-    baseTime: reduceMeasures(measures, 'baseTime'),
+  return _.mapValues(perExampleMeasures, (profilerMeasures: ProfilerMeasure[]) => ({
+    actualTime: reduceMeasures(profilerMeasures, 'actualTime'),
+    baseTime: reduceMeasures(profilerMeasures, 'baseTime'),
   }))
 }
 

build/gulp/tasks/stats.ts

@@ -46,9 +46,9 @@ const semverCmp = (a, b) => {
   return 0
 }
 
-function webpackAsync(config): Promise<any> {
+function webpackAsync(webpackConfig): Promise<any> {
   return new Promise((resolve, reject) => {
-    const compiler = webpack(config)
+    const compiler = webpack(webpackConfig)
     compiler.run((err, stats) => {
       const statsJson = stats.toJson()
       const { errors, warnings } = statsJson
@@ -73,14 +73,14 @@ function webpackAsync(config): Promise<any> {
 
 async function compileOneByOne(allConfigs) {
   let assets = []
-  for (const config of allConfigs) {
-    log('Compiling', config.output.filename)
+  for (const webpackConfig of allConfigs) {
+    log('Compiling', webpackConfig.output.filename)
     try {
-      const result = await webpackAsync(config)
+      const result = await webpackAsync(webpackConfig)
       assets = [...assets, ...result.assets]
       log('Done', result.assets[0].name) // All builds should produce just single asset
     } catch (err) {
-      log('Error', config.output.filename)
+      log('Error', webpackConfig.output.filename)
       throw err
     }
   }

build/gulp/tasks/test-projects.tsx

@@ -23,7 +23,7 @@ const log = (context: string) => (message: string) => {
   console.log('='.repeat(80))
 }
 
-export const runIn = path => cmd => sh(`cd ${path} && ${cmd}`)
+export const runIn = targetPath => cmd => sh(`cd ${targetPath} && ${cmd}`)
 
 const addResolutionPathsForStardustPackages = async (
   testProjectDir: string,
@@ -136,7 +136,6 @@ task('test:projects:cra-ts', async () => {
   const logger = log('test:projects:cra-ts')
   const scaffoldPath = paths.base.bind(null, 'build/gulp/tasks/test-projects/cra')
 
-  //////// CREATE TEST REACT APP ///////
   logger('STEP 1. Create test React project with TSX scripts..')
 
   const testAppPath = paths.withRootAt(
@@ -146,19 +145,16 @@ task('test:projects:cra-ts', async () => {
   const runInTestApp = runIn(testAppPath())
   logger(`Test React project is successfully created: ${testAppPath()}`)
 
-  //////// ADD STARDUST AS A DEPENDENCY ///////
   logger('STEP 2. Add Stardust dependency to test project..')
 
   const packedPackages = await packStardustPackages(logger)
   await addResolutionPathsForStardustPackages(testAppPath(), packedPackages)
   await runInTestApp(`yarn add ${packedPackages['@stardust-ui/react']}`)
   logger(`✔️Stardust UI packages were added to dependencies`)
 
-  //////// REFERENCE STARDUST COMPONENTS IN TEST APP's MAIN FILE ///////
   logger("STEP 3. Reference Stardust components in test project's App.tsx")
   fs.copyFileSync(scaffoldPath('App.tsx'), testAppPath('src', 'App.tsx'))
 
-  //////// BUILD TEST PROJECT ///////
   logger('STEP 4. Build test project..')
   await runInTestApp(`yarn build`)
 

build/gulp/tasks/test-vulns.ts

@@ -14,9 +14,9 @@ const SCAN_RESULTS_DIR_PATH = paths.base(SCAN_RESULTS_DIR_NAME)
 const log = message => debug.log(message)
 log.success = message => debug.log(`✔ ${message}`)
 
-const ensureDirExists = path => {
-  if (!fs.existsSync(path)) {
-    sh(`mkdir -p ${path}`)
+const ensureDirExists = directoryPath => {
+  if (!fs.existsSync(directoryPath)) {
+    sh(`mkdir -p ${directoryPath}`)
   }
 }
 

docs/src/app.tsx

@@ -1,5 +1,4 @@
 import * as React from 'react'
-import * as _ from 'lodash'
 import { Provider, themes } from '@stardust-ui/react'
 
 import { mergeThemes } from 'src/lib'

docs/src/components/ComponentDoc/ComponentPropsTable/ComponentPropsRow.tsx

@@ -43,13 +43,13 @@ export default class ComponentPropsRow extends React.Component<any, any> {
         <td>
           <ComponentPropDescription description={description} />
           {/* TODO change these according to the react-docgen-typescript generated json */}
-          {/*<ComponentPropFunctionSignature name={name} tags={tags} />*/}
-          {/*<ComponentPropEnum*/}
-          {/*showAll={showEnums}*/}
-          {/*toggle={this.toggleEnums}*/}
-          {/*type={type}*/}
-          {/*values={value}*/}
-          {/*/>*/}
+          {/* <ComponentPropFunctionSignature name={name} tags={tags} /> */}
+          {/* <ComponentPropEnum */}
+          {/* showAll={showEnums} */}
+          {/* toggle={this.toggleEnums} */}
+          {/* type={type} */}
+          {/* values={value} */}
+          {/* /> */}
         </td>
       </tr>
     )

docs/src/components/ComponentDoc/PerfChart/PerfDataProvider.tsx

@@ -27,8 +27,8 @@ const PerfDataProvider: React.FC = ({ children }) => {
           setData(responseJson)
           setLoading(false)
         })
-        .catch(error => {
-          setError(error)
+        .catch(e => {
+          setError(e)
           setLoading(false)
         })
     }

docs/src/components/ComponentPlayground.tsx

@@ -13,12 +13,12 @@ type ComponentPlaygroundProps = {
 }
 
 const ComponentPlayground: React.FunctionComponent<ComponentPlaygroundProps> = props => {
-  const playgroundPath = _.find(playgroundPaths, playgroundPath =>
+  const resultPath = _.find(playgroundPaths, playgroundPath =>
     _.includes(playgroundPath, `/${props.componentName}/`),
   )
 
-  if (playgroundPath) {
-    const PlaygroundComponent: React.FunctionComponent = examplePlaygroundContext(playgroundPath)
+  if (resultPath) {
+    const PlaygroundComponent: React.FunctionComponent = examplePlaygroundContext(resultPath)
       .default
 
     return (