addressed Roman's comments

Author: bmdalex

src/lib/factories.tsx

@@ -105,16 +105,18 @@ function createShorthandFromValue(
   const valIsNoop = _.isNil(value) || typeof value === 'boolean'
   if (valIsNoop && !options.render) return null
 
-  // return value as is if it a ReactElement
-  if (React.isValidElement(value)) {
-    return value as React.ReactElement<Props>
-  }
-
   const valIsPrimitive = typeof value === 'string' || typeof value === 'number'
   const valIsPropsObject = _.isPlainObject(value)
+  const valIsReactElement = React.isValidElement(value)
 
   // unhandled type warning
-  if (process.env.NODE_ENV !== 'production' && !valIsPrimitive && !valIsPropsObject && !valIsNoop) {
+  if (
+    process.env.NODE_ENV !== 'production' &&
+    !valIsPrimitive &&
+    !valIsPropsObject &&
+    !valIsReactElement &&
+    !valIsNoop
+  ) {
     console.error(
       [
         'Shorthand value must be a string|number|object|ReactElements.',
@@ -124,6 +126,11 @@ function createShorthandFromValue(
     )
   }
 
+  // return value 'as is' if it a ReactElement
+  if (valIsReactElement) {
+    return value as React.ReactElement<Props>
+  }
+
   // ----------------------------------------
   // Build up props
   // ----------------------------------------

test/specs/components/RadioGroup/RadioGroup-test.tsx

@@ -103,7 +103,7 @@ describe('RadioGroup', () => {
 
     if (isShorthandApiTest) {
       describe('click event handler', () => {
-        it('should set the value when item is clicked', () => {
+        it('should set "checked" when item is clicked', () => {
           const checkedValueChanged = jest.fn()
           const wrapper = mountWithProvider(
             <RadioGroup items={getItems()} checkedValueChanged={checkedValueChanged} />,
@@ -150,7 +150,7 @@ describe('RadioGroup', () => {
     })
 
     if (isShorthandApiTest) {
-      it('should not set the value when disabled item is clicked', () => {
+      it('should not set "checked" when disabled item is clicked', () => {
         const wrapper = mountWithProvider(<RadioGroup items={getItems({ disabledItem: 1 })} />)
         const radioGroupItems = wrapper.find('RadioGroupItem')
 

test/specs/lib/factories-test.tsx

@@ -525,11 +525,13 @@ describe('factories', () => {
         testCreateShorthand(
           {
             Component: 'p',
-            value: <span {...{ common: 'user', user: true } as any} />,
-            defaultProps: { common: 'default', default: true },
-            overrideProps: { common: 'override', override: true },
+            value: (
+              <span {...{ commonProp: 'originalElement', originalElementProp: true } as any} />
+            ),
+            defaultProps: { commonProp: 'default', defaultProp: true },
+            overrideProps: { commonProp: 'override', overrideProp: true },
           },
-          { common: 'user', user: true },
+          { commonProp: 'originalElement', originalElementProp: true },
         )
       })
     })