Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

[Enterprise Bot Generator][TypeScript] Incorrect name of gitignore file #792

Closed
Batta32 opened this issue Feb 14, 2019 · 0 comments
Closed

Comments

@Batta32
Copy link
Collaborator

Batta32 commented Feb 14, 2019

Project
Enterprise Bot Template

Description
Generating a bot using yo botbuilder-enterprise, creates a gitignore file without the dot prefix.

To Reproduce

  1. Go to AI/templates/Enterprise-Template/src/typescript/generator-botbuilder-enterprise
  2. Run npm pack and save the name of the package generated
  3. Run npm i -g <name_of_your_package>
  4. Run yo botbuilder-enterprise wherever you want to create your bot
  5. Check that the gitignore file does not contain a dot prefix

Expected behavior
The generated bot should contain a .gitignore file

Screenshots
-

Additional context
As stated in npm/npm#1862, when publishing a package (or using npm pack and installing it locally) the .gitignore file is replaced with a .npmignore file, that's why the gitignore file inside the template shouldn't be renamed to .gitignore.

@lauren-mills lauren-mills removed Status: Backlog This will go in the product backlog Status: Committed This has been confirmed for the next release. Type: Suggestion labels Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants