From 842ce1678fd39451f8c14d8af49a4b7adaa77746 Mon Sep 17 00:00:00 2001 From: Qiutong Shen Date: Thu, 11 Sep 2025 10:37:55 +0800 Subject: [PATCH] fix: resolve C4100 unreferenced parameter warnings across samples --- .../S2_CrashRecovery.xaml.cpp | 2 +- .../CppWinUiDesktopState/MainWindow.xaml.cpp | 20 +++++++++---------- .../cpp-winui/PhotoEditor/MainPage.xaml.cpp | 2 +- .../CountingWidgetImpl.cpp | 2 +- .../WeatherWidgetImpl.cpp | 4 ++-- .../SampleWidgetProviderApp/WidgetImplBase.h | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/Samples/AppLifecycle/RestartRegistration/cpp-winui-packaged/S2_CrashRecovery.xaml.cpp b/Samples/AppLifecycle/RestartRegistration/cpp-winui-packaged/S2_CrashRecovery.xaml.cpp index 59840fd78..e35ab127b 100644 --- a/Samples/AppLifecycle/RestartRegistration/cpp-winui-packaged/S2_CrashRecovery.xaml.cpp +++ b/Samples/AppLifecycle/RestartRegistration/cpp-winui-packaged/S2_CrashRecovery.xaml.cpp @@ -83,7 +83,7 @@ namespace winrt::cpp_winui_packaged::implementation *((int*)nullptr) = 0; } - void S2_CrashRecovery::OnNavigatedFrom(winrt::Microsoft::UI::Xaml::Navigation::NavigationEventArgs e) + void S2_CrashRecovery::OnNavigatedFrom(winrt::Microsoft::UI::Xaml::Navigation::NavigationEventArgs /*e*/) { _timer.Stop(); } diff --git a/Samples/AppLifecycle/StateNotifications/cpp/cpp-winui-packaged/CppWinUiDesktopState/CppWinUiDesktopState/MainWindow.xaml.cpp b/Samples/AppLifecycle/StateNotifications/cpp/cpp-winui-packaged/CppWinUiDesktopState/CppWinUiDesktopState/MainWindow.xaml.cpp index 013f0f4dd..2b4282e01 100644 --- a/Samples/AppLifecycle/StateNotifications/cpp/cpp-winui-packaged/CppWinUiDesktopState/CppWinUiDesktopState/MainWindow.xaml.cpp +++ b/Samples/AppLifecycle/StateNotifications/cpp/cpp-winui-packaged/CppWinUiDesktopState/CppWinUiDesktopState/MainWindow.xaml.cpp @@ -61,25 +61,25 @@ void winrt::CppWinUiDesktopState::implementation::MainWindow::OutputFormattedMes void winrt::CppWinUiDesktopState::implementation::MainWindow::RegisterPowerManagerCallbacks() { batteryToken = PowerManager::BatteryStatusChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnBatteryStatusChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnBatteryStatusChanged(); }); powerToken = PowerManager::PowerSupplyStatusChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnPowerSupplyStatusChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnPowerSupplyStatusChanged(); }); powerSourceToken = PowerManager::PowerSourceKindChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnPowerSourceKindChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnPowerSourceKindChanged(); }); chargeToken = PowerManager::RemainingChargePercentChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnRemainingChargePercentChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnRemainingChargePercentChanged(); }); dischargeToken = PowerManager::RemainingDischargeTimeChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnRemainingDischargeTimeChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnRemainingDischargeTimeChanged(); }); displayToken = PowerManager::DisplayStatusChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnDisplayStatusChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnDisplayStatusChanged(); }); energyToken = PowerManager::EnergySaverStatusChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnEnergySaverStatusChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnEnergySaverStatusChanged(); }); powerModeToken = PowerManager::EffectivePowerModeChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnPowerModeChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnPowerModeChanged(); }); userPresenceToken = PowerManager::UserPresenceStatusChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnUserPresenceStatusChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnUserPresenceStatusChanged(); }); systemSuspendToken = PowerManager::SystemSuspendStatusChanged([&]( - const auto&, winrt::Windows::Foundation::IInspectable obj) { OnSystemSuspendStatusChanged(); }); + const auto&, winrt::Windows::Foundation::IInspectable /*obj*/) { OnSystemSuspendStatusChanged(); }); if (batteryToken && powerToken && powerSourceToken && chargeToken && dischargeToken) { diff --git a/Samples/PhotoEditor/cpp-winui/PhotoEditor/MainPage.xaml.cpp b/Samples/PhotoEditor/cpp-winui/PhotoEditor/MainPage.xaml.cpp index 34ff2649f..75dc21139 100644 --- a/Samples/PhotoEditor/cpp-winui/PhotoEditor/MainPage.xaml.cpp +++ b/Samples/PhotoEditor/cpp-winui/PhotoEditor/MainPage.xaml.cpp @@ -214,7 +214,7 @@ namespace winrt::PhotoEditor::implementation } // Photo clicked event handler for navigation to DetailPage view. - void MainPage::ImageGridView_ItemClick(IInspectable const sender, ItemClickEventArgs const e) + void MainPage::ImageGridView_ItemClick(IInspectable const /*sender*/, ItemClickEventArgs const e) { // Prepare the connected animation for navigation to the detail page. m_persistedItem = e.ClickedItem().as(); diff --git a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/CountingWidgetImpl.cpp b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/CountingWidgetImpl.cpp index 5c4773a2f..ed9f6e703 100644 --- a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/CountingWidgetImpl.cpp +++ b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/CountingWidgetImpl.cpp @@ -51,7 +51,7 @@ void CountingWidget::OnActionInvoked(winrt::WidgetActionInvokedArgs actionInvoke } // This function will be invoked when WidgetContext has changed. -void CountingWidget::OnWidgetContextChanged(winrt::WidgetContextChangedArgs contextChangedArgs) +void CountingWidget::OnWidgetContextChanged(winrt::WidgetContextChangedArgs /*contextChangedArgs*/) { // (Optional) There a several things that can be done here: // 1. If you need to adjust template/data for the new context (i.e. widget size has chaned) - you can do it here. diff --git a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WeatherWidgetImpl.cpp b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WeatherWidgetImpl.cpp index d7f515b77..0f83a55d2 100644 --- a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WeatherWidgetImpl.cpp +++ b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WeatherWidgetImpl.cpp @@ -7,12 +7,12 @@ WeatherWidget::WeatherWidget(winrt::hstring const& id, winrt::hstring const& state) : WidgetImplBase(id, state) {} // This function wil be invoked when the Increment button was clicked by the user. -void WeatherWidget::OnActionInvoked(winrt::WidgetActionInvokedArgs actionInvokedArgs) +void WeatherWidget::OnActionInvoked(winrt::WidgetActionInvokedArgs /*actionInvokedArgs*/) { } // This function will be invoked when WidgetContext has changed. -void WeatherWidget::OnWidgetContextChanged(winrt::WidgetContextChangedArgs contextChangedArgs) +void WeatherWidget::OnWidgetContextChanged(winrt::WidgetContextChangedArgs /*contextChangedArgs*/) { // This function is raised when // (Optional) There a several things that can be done here: diff --git a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WidgetImplBase.h b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WidgetImplBase.h index d0cd80305..742f362fa 100644 --- a/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WidgetImplBase.h +++ b/Samples/Widgets/cpp-win32-packaged/SampleWidgetProviderApp/WidgetImplBase.h @@ -15,10 +15,10 @@ class WidgetImplBase void State(winrt::hstring const& state) { m_state = state; }; - virtual void Activate(winrt::Microsoft::Windows::Widgets::Providers::WidgetContext widgetContext) {}; + virtual void Activate(winrt::Microsoft::Windows::Widgets::Providers::WidgetContext /*widgetContext*/) {}; virtual void Deactivate(winrt::hstring) {}; - virtual void OnActionInvoked(winrt::WidgetActionInvokedArgs actionInvokedArgs) {}; - virtual void OnWidgetContextChanged(winrt::WidgetContextChangedArgs contextChangedArgs) {}; + virtual void OnActionInvoked(winrt::WidgetActionInvokedArgs /*actionInvokedArgs*/) {}; + virtual void OnWidgetContextChanged(winrt::WidgetContextChangedArgs /*contextChangedArgs*/) {}; virtual winrt::hstring GetTemplateForWidget() = 0; virtual winrt::hstring GetDataForWidget() = 0;