Skip to content

Fix debug.ts __debugKind check #50871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Sep 21, 2022

Fixes my oops in #50422.

The old code was:

if (!ctor.prototype.hasOwnProperty("__debugKind")) { ... }

Which I changed to:

if (!hasProperty(ctor, "__debugKind")) { ... }

But it should have been:

if (!hasProperty(ctor.prototype, "__debugKind")) { ... }

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 21, 2022
@DanielRosenwasser DanielRosenwasser merged commit e383db6 into microsoft:main Sep 21, 2022
@DanielRosenwasser
Copy link
Member

Thanks!

@jakebailey jakebailey deleted the fix-my-oops-1 branch September 21, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants