From ef0dac0a22e6e7dd17d9c9634f7c3571472baa24 Mon Sep 17 00:00:00 2001 From: hantatsang Date: Sun, 25 Apr 2021 21:18:33 +1000 Subject: [PATCH] sort deprecated completions lower than others --- src/server/session.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/server/session.ts b/src/server/session.ts index 93013251e1ef4..9cd8ee322686a 100644 --- a/src/server/session.ts +++ b/src/server/session.ts @@ -1844,7 +1844,10 @@ namespace ts.server { // Use `hasAction || undefined` to avoid serializing `false`. return { name, kind, kindModifiers, sortText, insertText, replacementSpan: convertedSpan, isSnippet, hasAction: hasAction || undefined, source, sourceDisplay, isRecommended, isPackageJsonImport, isImportStatementCompletion, data }; } - }), (a, b) => compareStringsCaseSensitiveUI(a.name, b.name)); + }), (a, b) => { + // Sort @deprecated completions lower than others first + return a.kindModifiers === ScriptElementKindModifier.deprecatedModifier ? 1 : b.kindModifiers === ScriptElementKindModifier.deprecatedModifier ? -1 : compareStringsCaseSensitiveUI(a.name, b.name); + }); if (kind === protocol.CommandTypes.Completions) { if (completions.metadata) (entries as WithMetadata).metadata = completions.metadata;