From 2e5a2dacbeb1a7695477ae7442e605c4cca8d468 Mon Sep 17 00:00:00 2001 From: kingwl Date: Wed, 15 Jul 2020 22:34:34 +0800 Subject: [PATCH 1/2] Fix incorrect deprecated mark --- src/compiler/checker.ts | 2 +- tests/cases/fourslash/jsdocDeprecated_suggestion7.ts | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/jsdocDeprecated_suggestion7.ts diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 1314f1ae34d1d..c0241cb0debda 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -30908,7 +30908,7 @@ namespace ts { } const symbol = getNodeLinks(node).resolvedSymbol; if (symbol) { - if (every(symbol.declarations, d => !isTypeDeclaration(d) || !!(d.flags & NodeFlags.Deprecated))) { + if (some(symbol.declarations, d => isTypeDeclaration(d) && !!(d.flags & NodeFlags.Deprecated))) { const diagLocation = isTypeReferenceNode(node) && isQualifiedName(node.typeName) ? node.typeName.right : node; errorOrSuggestion(/* isError */ false, diagLocation, Diagnostics._0_is_deprecated, symbol.escapedName as string); } diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts new file mode 100644 index 0000000000000..ed14494fdabf6 --- /dev/null +++ b/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts @@ -0,0 +1,9 @@ +/// + +//// enum Direction { +//// Left = -1, +//// Right = 1, +//// } +//// type T = Direction.Left + +verify.getSuggestionDiagnostics([]); From af7d42be0bb0d1230063d3bd129578dea7d40e27 Mon Sep 17 00:00:00 2001 From: kingwl Date: Wed, 15 Jul 2020 22:47:33 +0800 Subject: [PATCH 2/2] improve test --- tests/cases/fourslash/jsdocDeprecated_suggestion7.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts index ed14494fdabf6..ff98ed0179f39 100644 --- a/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts +++ b/tests/cases/fourslash/jsdocDeprecated_suggestion7.ts @@ -6,4 +6,9 @@ //// } //// type T = Direction.Left +//// /** @deprecated */ +//// const x = 1 +//// type x = string +//// var y: x = 'hi' + verify.getSuggestionDiagnostics([]);