Skip to content

Make debug mode work with new VS Code JS debugger #39098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2020
Merged

Make debug mode work with new VS Code JS debugger #39098

merged 1 commit into from
Jun 16, 2020

Conversation

andrewbranch
Copy link
Member

Debug launch scripts no longer set --inspect or --inspect-brk on the node executable.

@andrewbranch andrewbranch requested a review from rbuckton June 16, 2020 22:39
sandersn
sandersn approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True story, the people in the gitter channel were delighted to find out about our debug methods and then were loudly disgusted when I pasted this code into the chat.

Anyway, 👍

@andrewbranch
Copy link
Member Author

Huh? Which Gitter?

@andrewbranch andrewbranch merged commit 540c219 into microsoft:master Jun 16, 2020
@andrewbranch andrewbranch deleted the new-debugger branch June 16, 2020 23:07
@sandersn
Copy link
Member

https://gitter.im/Microsoft/TypeScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@andrewbranch andrewbranch

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewbranch @sandersn @typescript-bot