Skip to content

Sort the arrays of fileNames in the build info #37541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

sheetalkamat
Copy link
Member

Earlier we did this in testing to ensure we could baseline now moved to actual build info writing
Fixes #37156

Earlier we did this in testing to ensure we could baseline now moved to actual build info writing
Fixes #37156
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but you may want to use a file path comparitor for the sort rather than the default alphanumeric; then again, it probably doesn't matter, so long as it's sorted in a stable fashion.

@sheetalkamat sheetalkamat merged commit 6c1e8aa into master Mar 25, 2020
@sheetalkamat sheetalkamat deleted the consistentBuildInfo branch March 25, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.tsbuildinfo output is non-deterministic
4 participants