Bind @class in the right place -- bindWorker not bindChildrenWorker
#34575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an assert to make future mismatches fail in an obvious place instead of in a while loop.
|
@rbuckton @andrewbranch @orta This needs to be fixed in 3.7 but we're slipping the RC snap until end of Friday or Monday some time, so this doesn't need to be reviewed in the next 15 minutes -- just the next day or so. |
|
Removing the |
orta
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add an assert to make future mismatches fail in an obvious place instead of in a while loop.
I believe the reason that this never failed before was that all of the tests had either
this.propassignments orF.prototype = { ...assignments, both of which also set theSymbolFlags.Classflag.Fixes #34346