add all-settled in promise #31085
Closed
add all-settled in promise #31085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
reviewed
Apr 24, 2019
src/lib/esnext.promise.d.ts
Outdated
| @@ -0,0 +1,74 @@ | |||
| /** @internal */ | |||
Contributor
There was a problem hiding this comment.
why is this internal? if it was stripped by stripInternal (I don't think it is), it would create an invalid declaration file.
Contributor
Author
|
seems ci is broken |
Member
|
Fixed merge conflicts, let's see how CI goes |
Member
|
♥ line ending problems |
Contributor
Author
|
Anything else needs me to update?🤔 |
Contributor
Author
|
🙋🏻♂️ |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31083
It's toooooooooo hard to write ten overload