From e2c4da8df30b238b4cd66b5bfe35ec18e4805b8d Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 4 Dec 2017 12:15:34 -0800 Subject: [PATCH 1/3] Added localization instructions to CONTRIBUTING.md Fixes #20418 --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6dbb7e514a0da..32367898d44cc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -183,3 +183,8 @@ jake baseline-accept ``` to establish the new baselines as the desired behavior. This will change the files in `tests\baselines\reference`, which should be included as part of your commit. It's important to carefully validate changes in the baselines. + +## Localization + +All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json). +If you make changes to it, run `jake generate-diagnostics` to push them to the generated localization and definition files. From b75c99009885148e320501876548e87341f613c4 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 4 Dec 2017 12:37:12 -0800 Subject: [PATCH 2/3] Corrected mention of generated ts file --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 32367898d44cc..6d93c1e145f8b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -187,4 +187,4 @@ to establish the new baselines as the desired behavior. This will change the fil ## Localization All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json). -If you make changes to it, run `jake generate-diagnostics` to push them to the generated localization and definition files. +If you make changes to it, run `jake generate-diagnostics` to push them to the generated [`diagnosticInformationMap.generated.ts`](./src/compiler/diagnosticInformationMap.generated.ts). From 22195dcf95c52386f8437e32b733e6627d9d1efd Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Sat, 9 Dec 2017 13:46:41 -0800 Subject: [PATCH 3/3] Mentioned coding guidelines --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6d93c1e145f8b..fd0f4348c624d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -187,4 +187,6 @@ to establish the new baselines as the desired behavior. This will change the fil ## Localization All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json). -If you make changes to it, run `jake generate-diagnostics` to push them to the generated [`diagnosticInformationMap.generated.ts`](./src/compiler/diagnosticInformationMap.generated.ts). +If you make changes to it, run `jake generate-diagnostics` to push them to the `Diagnostic` interface in [`diagnosticInformationMap.generated.ts`](./src/compiler/diagnosticInformationMap.generated.ts). + +See [coding guidelines on diagnostic messages](https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines#diagnostic-messages).