space-before-function-paren

[aochsner]

Adding option InsertSpaceBeforeFunctionParenthesis
Should be optional
Typically used to support http://eslint.org/docs/rules/space-before-function-paren

Fixes #12234

Fixes #

[msftclas]

Hi @aochsner, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

[aochsner]

Realized that this test will fail... any suggestions as to how to fix? Guessing that it is conflicting w/ SpaceAfterFunctionInFuncDecl

/////*3*/var anonymousWithoutSpace = function() {};
goTo.marker('3');
verify.currentLineContentIs('var anonymousWithoutSpace = function () { };');

[aochsner]

wrt anon functions looks like there's a different toggle:
InsertSpaceAfterFunctionKeywordForAnonymousFunctions

[aochsner]

Okay. I added a couple more test cases for InsertSpaceBeforeFunctionParenthesis. Found InsertSpaceAfterFunctionKeywordForAnonymousFuctions to cover that case. Added InsertSpaceAfterConstructor to handle that case. That should cover the main cases that http://eslint.org/docs/rules/space-before-function-paren enforces.

Let me know what else should be done. Thanks!