Disallow old style octal literal types #13016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for master green build |
|
Will need to rebase onto #13025 (when it's merged) to fix tests. |
mhegazy
approved these changes
Dec 19, 2016
mihailik
reviewed
Dec 20, 2016
| var n = 0x1; | ||
| var n = -1; | ||
| var n = -1.0; | ||
| var n = -1e-4; | ||
| var n = -003; // Error in ES5 | ||
| ~~~ | ||
| !!! error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. | ||
| !!! error TS1085: Octal literals are not available when targeting ECMAScript 5 and higher. Use the syntax '0o3'. |
There was a problem hiding this comment.
0o3 is not the same as -003.
There was a problem hiding this comment.
@mihailik
Thank you for review. I can improve reporting asap.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10101