Skip to content

Right paren is not a completion commit character #9424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Peter-Juhasz opened this issue Jun 29, 2016 · 4 comments
Closed

Right paren is not a completion commit character #9424

Peter-Juhasz opened this issue Jun 29, 2016 · 4 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio

Comments

@Peter-Juhasz
Copy link

Visual Studio 2015 Update 3
TypeScript Version: 1.8.34

Code
image

Expected behavior:
I type the next character ')' without fully typing the word or explicitly committing the selected completion item by Enter; the completion item gets committed and the character I typed gets inserted at the next position.
image

Actual behavior:
Completion does not happen, the completion session gets dismissed but the character gets typed, so I end up in an incorrect state.
image

This behavior is really frustrating, because almost every time I start typing a word then write the next character fluently ('.', ',' '(', ...), the code gets messed up.

@DanielRosenwasser DanielRosenwasser changed the title Selected completion item does not get committed by typing fluently Right paren is not a completion commit charactr Jun 29, 2016
@DanielRosenwasser DanielRosenwasser changed the title Right paren is not a completion commit charactr Right paren is not a completion commit character Jun 29, 2016
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Visual Studio Integration with Visual Studio labels Jun 29, 2016
@Peter-Juhasz
Copy link
Author

Hey @DanielRosenwasser the title you changed the bug to is wrong. Not only "right paren" but all completion characters do not work. So please change it back, because the overall behavior of commiting on specific characters does not work.

@Peter-Juhasz
Copy link
Author

@DanielRosenwasser did you read the issue definition completely? Because it not applies only to right parenthesis but all characters which you can write next right after completion, like dot, space and so on.

@paulvanbrenk paulvanbrenk modified the milestones: TypeScript 2.1, TypeScript 2.0.1 Jul 14, 2016
@paulvanbrenk
Copy link
Contributor

I have a fix for this, and it should be part of the final 2.0 release.

@dudeNumber4
Copy link

Very confused. Using 2.1.6 and this is still an issue. Should it not be?

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Projects
None yet
Development

No branches or pull requests

4 participants