-
Notifications
You must be signed in to change notification settings - Fork 12.8k
autoImportSpecifierExcludeRegexes needs a window refresh for changes to take effect #60082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mjbvz checked manually and I don't see anything in the server log where the updated setting gets sent over |
@188599 What VS Code version are you using? Support for this setting was only added in the last month |
1.94-insider |
@RyanCavanaugh Can you also tru this out on in insiders. I see the field getting sent over in the |
This is only tangentially related to the issue, but as I was digging through the code trying to figure out why .vscode/settings.json {
"typescript.preferences.autoImportFileExcludePatterns": ["@ionic/angular/commons", "@ionic/angular"]
} And instead of excluding those 2 import paths, it was removing all import paths under It seemed to me that due to recent changes to What I was left wondering is, is the current behavior from |
Same issues here (including the one from the OP). As a workaround for Ionic, I'm using: {
"typescript.preferences.autoImportSpecifierExcludeRegexes": ["^@ionic\/angular\/common$", "^@ionic\/angular$", "\/proxies$"]
} |
Same here. Though restarting the TS server also works. |
🔎 Search Terms
autoImportSpecifierExcludeRegexes
🕗 Version & Regression Information
⏯ Playground Link
No response
💻 Code
.vscode/settings.json
🙁 Actual behavior
Changes only take effect after a window reload.
🙂 Expected behavior
Changes to take effect immediately, same way that
autoImportFileExcludePatterns
does.Additional information about the issue
I mentioned this earlier on another issue (#35395 (comment)) and I initially thought that the update I got fixed the problem, turns out it was just because that forced the window to refresh, as I later encountered the same problem once I tried adding new regexes to it.
The text was updated successfully, but these errors were encountered: