Skip to content

autoImportSpecifierExcludeRegexes needs a window refresh for changes to take effect #60082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
188599 opened this issue Sep 27, 2024 · 7 comments
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@188599
Copy link

188599 commented Sep 27, 2024

🔎 Search Terms

autoImportSpecifierExcludeRegexes

🕗 Version & Regression Information

  • This changed between versions ______ and _______
  • This changed in commit or PR _______
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
  • I was unable to test this on prior versions because _______

⏯ Playground Link

No response

💻 Code

.vscode/settings.json

{
  "<language>.preferences.autoImportSpecifierExcludeRegexes": ["<regex>"]
}

🙁 Actual behavior

Changes only take effect after a window reload.

🙂 Expected behavior

Changes to take effect immediately, same way that autoImportFileExcludePatterns does.

Additional information about the issue

I mentioned this earlier on another issue (#35395 (comment)) and I initially thought that the update I got fixed the problem, turns out it was just because that forced the window to refresh, as I later encountered the same problem once I tried adding new regexes to it.

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Sep 27, 2024
@RyanCavanaugh
Copy link
Member

@mjbvz checked manually and I don't see anything in the server log where the updated setting gets sent over

@mjbvz
Copy link
Contributor

mjbvz commented Sep 27, 2024

@188599 What VS Code version are you using? Support for this setting was only added in the last month

@188599
Copy link
Author

188599 commented Sep 27, 2024

@188599 What VS Code version are you using? Support for this setting was only added in the last month

1.94-insider

@mjbvz
Copy link
Contributor

mjbvz commented Sep 27, 2024

@RyanCavanaugh Can you also tru this out on in insiders. I see the field getting sent over in the configure request for the file:

Image

@188599
Copy link
Author

188599 commented Sep 27, 2024

This is only tangentially related to the issue, but as I was digging through the code trying to figure out why autoImportFileExcludePatterns was seemingly not working as intended, with the code provided on a new Ionic project, they bundle it in with the following:

.vscode/settings.json

{
  "typescript.preferences.autoImportFileExcludePatterns": ["@ionic/angular/commons", "@ionic/angular"]
}

And instead of excluding those 2 import paths, it was removing all import paths under @ionic/angular, where the required imports are all from @ionic/angular/standalone.

It seemed to me that due to recent changes to autoImportFileExcludePatterns the old behavior was changed and this why autoImportSpecifierExcludeRegexes came about to make up for it.

What I was left wondering is, is the current behavior from autoImportFileExcludePatterns mentioned above intended? It feels like it shouldn't be either.

@kafumanto
Copy link

{
"typescript.preferences.autoImportFileExcludePatterns": ["@ionic/angular/commons", "@ionic/angular"]
}

Same issues here (including the one from the OP). As a workaround for Ionic, I'm using:

{
    "typescript.preferences.autoImportSpecifierExcludeRegexes": ["^@ionic\/angular\/common$", "^@ionic\/angular$", "\/proxies$"]
}

@tusharsnx
Copy link

tusharsnx commented Apr 5, 2025

autoImportSpecifierExcludeRegexes needs a window refresh for changes to take effect

Same here. Though restarting the TS server also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

No branches or pull requests

5 participants