instanceof has been used and there is a type inference error

[moshuying]

🔎 Search Terms

Property 'dispose' does not exist on type 'string | number | boolean | Record<string, any> | Color | ((material: Material) => Material)

🕗 Version & Regression Information

⏯ Playground Link

No response

💻 Code

export function disposeMaterial(material: THREE.Material) {
  if (material instanceof THREE.Material) {
    for (const key in material) {
      const k = key as keyof THREE.Material
      if (material[k] instanceof THREE.Texture) {
        //@ts-ignore 
        material[k].dispose()
      }
    }
    material.dispose()
  }
}

🙁 Actual behavior

no error

🙂 Expected behavior

no error

Additional information about the issue

No response

[moshuying]

I can fix it, but I don't think it's right

export function disposeMaterial(material: THREE.Material) {
  if (material instanceof THREE.Material) {
    for (const key in material) {
      const k = key as keyof THREE.Material
      const e = material[k]
      if (e instanceof THREE.Texture) {
        // 销毁纹理
        e.dispose()
      }
    }
    // 销毁材质
    material.dispose()
  }
}

[Andarist]

The upcoming 5.5 release fixes this: #57847

[typescript-bot]

This issue has been marked as "Duplicate" and has seen no recent activity. It has been automatically closed for house-keeping purposes.