Same references from different (but not found) modules

[jkillian]

If you have code like the following:

import { resolve as resolveUrl } from 'url';
import { resolve } from 'path';

getDocumentHighlights marks both references of resolve as the same if the modules 'url' and 'path' can't be found. However, if 'url' and 'path' can be found, it correctly differentiates between the two.

I know this is somewhat of an edge-case, but is this intended behavior? Or is it a bug?

[mhegazy]

they both given the same symbol (unknownSymbol), the find all references code will think they are because they also have the same name. we could exclude the unknownSymbol from this logic. but would not say it is a priority.

[Andarist]

I can't repro this using "Find all references" using this code:

import { resolve as resolveUrl } from "idontcare";
import { resolve } from "whatever";

So perhaps the issue could be assumed to be fixed, cc @jakebailey

[jakebailey]

Thanks for checking; I bisected and this was fixed in e8c3d54, but it's not clear to me that this actually has a test and it'd be nice to have one via a fourslash baseline or something.