Skip to content

Formatter does not treat destructured imports #5164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpasero opened this issue Oct 8, 2015 · 2 comments
Closed

Formatter does not treat destructured imports #5164

bpasero opened this issue Oct 8, 2015 · 2 comments
Labels
Bug A bug in TypeScript Help Wanted You can do this
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 8, 2015

Imagine an import like this:

import { IWorkbenchEditorService }  from 'vs/workbench/services/editor/common/editorService';

Format, I would love if it ends up to be

import {IWorkbenchEditorService}  from 'vs/workbench/services/editor/common/editorService';

Or whatever you guys think should be the formatting of destructured imports.

@mhegazy mhegazy added the Bug A bug in TypeScript label Oct 8, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Oct 8, 2015

I have seen users have strong opinions on weather this should have spaces or not. so looks like this can be a new option.

//CC: @saschanaz

@saschanaz
Copy link
Contributor

Unmerged #4609 will format the code but with spaces. A new option for this will be good but maybe after #4757.

@mhegazy mhegazy added this to the Community milestone Dec 8, 2015
@mhegazy mhegazy added the Help Wanted You can do this label Dec 8, 2015
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
@bpasero bpasero closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

4 participants