Optional Chaining and Type Narrowing

[ghost]

🔎 Search Terms

Optional Chaining, as Operator, Type Narrowing

🕗 Version & Regression Information

v4.6.2, 'Nightly' version as well

⏯ Playground Link

https://www.typescriptlang.org/play?#code/C4TwDgpgBAkgtgQwObQLxQN4CgpQGYD2ATosAM4BcUZwRAlgHZIDaAumwNxYC+WWokKAAUiBACYBXAMbAo6bLjqIUlWMohsoAHygMJAG31de-cNACCUqRDJliIOZhMCLYsQQaOFUMKMkyqEXFpWR1La1t7bV0DIx4+PAkGGToPKCkACwgpAGsACgQ3D1VzIoY2AEpMHCg6PCg8grKyZgAGVgB+ADpfYJkoBDJhPxCK7qVkG279CCZgDKrvXCli2Tw6Ihp4Sccm9wYW9p6R-sHhvuAKromVNtYuXF5uIA

💻 Code

type Image = {
  formats: string[][];
}

type Product = {
  images: Image[] | null;
}

type Accessory = {}

type Addon = {
  product: Product | Accessory | null;
}

function check(addons: Addon[]) {
  if ((addons[0]?.product as Product)?.images?.length) {
    const firstImage = (addons[0].product as Product).images[0];
  }
}

🙁 Actual behavior

Errors in code: Object is possibly 'null'

🙂 Expected behavior

No errors

Additional note

If you remove 'Accessory' type at all and remove the 'as' operator, everything will work fine

[MartinJohns]

Narrowing only occurs on specific syntax. By using a type assertion the compiler is losing the context to the variable and can't narrow it anymore. You can narrow a variable, such as addons[0]?.product, but you can't narrow an expression like addons[0]?.product as Product. I'm sure I've seen an issue about this already, but I can't find it anymore right now. (edit: Semi related: #34974 (comment))

A simple workaround is to store type-asserted value in a variable and then narrow the variable:

const product = addons[0]?.product as Product | undefined;
if (product?.images?.length) {
  const firstImage = product.images[0];
}

---

Side-note: The {} type does not mean an object without any properties. I hope you're aware of this.

[ghost]

Thanks for clarification @MartinJohns . Close the issue