Regression: Incorrect parse error when decorated class member follows non-semicolon-terminated property declaration

[typescript-bot]

The following errors were reported by 4.4.0-dev.20210722, but not by 4.3.5

ant-design/ant-design

tsconfig.json

• error TS2359: The right-hand side of an 'instanceof' expression must be of type 'any' or of a type assignable to the 'Function' interface type.
  • components/_util/scrollTo.ts#L26
• error TS2339: Property 'nodeType' does not exist on type 'ChildNode'.
  • components/typography/util.tsx#L143
  • components/typography/util.tsx#L207
• error TS2345: Argument of type 'ChildNode' is not assignable to parameter of type 'Node'.
  • components/typography/util.tsx#L160
  • components/typography/util.tsx#L165
  • components/typography/util.tsx#L220
• error TS2339: Property 'textContent' does not exist on type 'ChildNode'.
  • components/typography/util.tsx#L227

vercel/hyper

2 of 3 projects failed to build with the old tsc

tsconfig.json

• error TS2571: Object is of type 'unknown'.
  • app/config/init.ts#L20 in app/tsconfig.json
  • app/plugins.ts#L298 in app/tsconfig.json
  • app/plugins.ts#L299 in app/tsconfig.json
  • app/plugins.ts#L301 in app/tsconfig.json
  • app/utils/cli-install.ts#L47 in app/tsconfig.json
  • app/utils/cli-install.ts#L47 in app/tsconfig.json
  • app/utils/cli-install.ts#L49 in app/tsconfig.json
  • app/utils/cli-install.ts#L51 in app/tsconfig.json
  • app/utils/cli-install.ts#L64 in app/tsconfig.json
  • app/session.ts#L158 in app/tsconfig.json
  • app/session.ts#L219 in app/tsconfig.json
  • app/session.ts#L231 in app/tsconfig.json

styled-components/styled-components

packages/styled-components/tsconfig.json

• error TS2571: Object is of type 'unknown'.
  • packages/styled-components/src/utils/checkDynamicCreation.ts#L45

typeorm/typeorm

tsconfig.json

• error TS1436: Decorators must precede the name and all keywords of property declarations.
  • test/functional/query-runner/view/PostMaterializedView.ts#L11
  • test/functional/query-runner/view/PostView.ts#L10
  • test/github-issues/6540/entity/order-product.entity.ts.ts#L9
  • test/github-issues/6540/entity/order.entity.ts.ts#L17
  • test/github-issues/6900/entity/Warn.ts#L8
  • test/github-issues/7283/entity/AccessEvent.ts#L9
  • test/github-issues/7283/entity/AccessEvent.ts#L12
  • test/github-issues/7283/entity/Employee.ts#L14
  • test/github-issues/7523/entity/Test.ts#L9
  • test/github-issues/7541/entity/Test.ts#L14
  • test/github-issues/7586/entity/Test.ts#L9
  • test/github-issues/7586/entity/ViewA.ts#L12
  • test/github-issues/7586/entity/ViewB.ts#L12
  • test/github-issues/7586/entity/ViewC.ts#L12
  • test/github-issues/7647/entity/TaskNotification.ts#L12
  • test/github-issues/7698/entity/Test.ts#L12
  • test/github-issues/7698/entity/Test.ts#L15

balena-io/etcher

1 of 2 projects failed to build with the old tsc

tsconfig.webpack.json

• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error | undefined'.
  • lib/gui/app/app.ts#L339
  • lib/gui/app/components/source-selector/source-selector.tsx#L412
  • lib/gui/app/components/source-selector/source-selector.tsx#L508
• error TS2571: Object is of type 'unknown'.
  • lib/gui/app/components/source-selector/source-selector.tsx#L411
  • lib/gui/app/modules/image-writer.ts#L224
  • lib/gui/app/modules/image-writer.ts#L225
  • lib/gui/app/modules/image-writer.ts#L293
  • lib/gui/app/pages/main/Flash.tsx#L122
  • lib/gui/app/pages/main/Flash.tsx#L124
  • lib/shared/catalina-sudo/sudo.ts#L54
  • lib/shared/catalina-sudo/sudo.ts#L55
  • lib/shared/catalina-sudo/sudo.ts#L58
  • lib/shared/catalina-sudo/sudo.ts#L58
  • lib/shared/permissions.ts#L64
  • lib/shared/permissions.ts#L150
  • lib/shared/permissions.ts#L199
  • lib/shared/permissions.ts#L205
  • lib/shared/permissions.ts#L208
  • lib/shared/permissions.ts#L210
  • lib/shared/permissions.ts#L212
• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • lib/gui/app/pages/main/Flash.tsx#L126
• error TS2322: Type 'string' is not assignable to type '"main" | "success"'.
  • lib/gui/app/pages/main/MainPage.tsx#L127
• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error & { description?: string | undefined; report?: boolean | undefined; code?: string | undefined; syscall?: string | undefined; errno?: number | undefined; stdout?: string | undefined; stderr?: string | undefined; device?: string | undefined; }'.
  • lib/gui/modules/child-writer.ts#L305

homebridge/homebridge

tsconfig.json

• error TS2571: Object is of type 'unknown'.
  • src/bridgeService.ts#L225
  • src/bridgeService.ts#L265
  • src/bridgeService.ts#L306
  • src/bridgeService.ts#L332
  • src/bridgeService.ts#L351
  • src/childBridgeService.ts#L416
  • src/pluginManager.ts#L130
  • src/pluginManager.ts#L162
  • src/pluginManager.ts#L323
  • src/pluginManager.ts#L332
  • src/pluginManager.ts#L352
  • src/pluginManager.ts#L369
  • src/server.ts#L290
  • src/server.ts#L318
  • src/server.ts#L359
  • src/server.ts#L388
  • src/server.ts#L416
• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
  • src/server.ts#L304
  • src/server.ts#L402

rome/tools

tsconfig.json

• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • internal/binary-transport/RSERStream.ts#L71
  • internal/binary-transport/RSERStream.ts#L116
  • internal/binary-transport/RSERStream.ts#L153
  • internal/cli-diagnostics/DiagnosticsPrinter.ts#L496
  • internal/cli-diagnostics/DiagnosticsPrinter.ts#L504
  • internal/codec-browsers/index.test.ts#L46
  • internal/core/client/Client.ts#L567
  • internal/core/client/Client.ts#L588
  • internal/core/client/ClientRequest.ts#L120
  • internal/core/common/FatalErrorHandler.ts#L53
  • internal/core/common/IntegrationLoader.ts#L106
  • internal/core/server/ServerClient.ts#L200
  • internal/core/server/ServerClient.ts#L329
  • internal/core/server/ServerRequest.ts#L894
  • internal/core/server/bundler/Bundler.ts#L374
  • internal/core/server/bundler/Bundler.ts#L376
  • internal/core/server/testing/TestServerWorker.ts#L329
  • internal/core/server/testing/TestServerWorker.ts#L395
  • internal/core/worker/Worker.ts#L145
  • internal/core/worker/test/TestAPI.ts#L715
  • internal/core/worker/test/TestAPI.ts#L744
  • internal/diagnostics/wrap.ts#L32
  • internal/diagnostics/wrap.ts#L90
  • internal/events/Bridge.ts#L461
  • internal/events/Bridge.ts#L668
  • internal/events/BridgeEvent.ts#L129
• error TS2571: Object is of type 'unknown'.
  • internal/core/client/ClientRequest.ts#L124
  • internal/core/common/FatalErrorHandler.ts#L149
  • internal/core/common/IntegrationLoader.ts#L87
  • internal/core/server/fs/MemoryFileSystem.ts#L956
  • internal/core/server/fs/RecoveryStore.ts#L424
  • internal/core/server/fs/RecoveryStore.ts#L448
  • internal/core/server/lsp/protocol.ts#L161
  • internal/core/worker/Worker.ts#L149
  • internal/core/worker/test/TestAPI.ts#L721
  • internal/core/worker/test/TestAPI.ts#L721
  • internal/core/worker/test/TestAPI.ts#L750
  • internal/core/worker/test/TestAPI.ts#L750
  • internal/core/worker/test/TestAPI.ts#L774
  • internal/core/worker/test/TestAPI.ts#L775
  • internal/core/worker/test/TestAPI.ts#L793
  • internal/core/worker/test/TestAPI.ts#L794
  • internal/path/classes/AbsoluteFilePath.ts#L335
  • internal/resources/index.ts#L76
  • internal/v8/error-frames.ts#L29
  • public-packages/vscode-extension/index.ts#L61
  • scripts/_utils.ts#L253
• error TS2322: Type 'unknown' is not assignable to type 'Error'.
  • internal/core/worker/test/TestWorkerFile.ts#L338
  • internal/core/worker/test/TestWorkerFile.ts#L547
  • internal/core/worker/test/TestWorkerFile.ts#L588
  • internal/core/worker/test/TestWorkerFile.ts#L634

GeekyAnts/NativeBase

2 of 3 projects failed to build with the old tsc

tsconfig.json

• error TS2698: Spread types may only be created from object types.
  • src/components/primitives/Icon/Icon.tsx#L20

sindresorhus/refined-github

tsconfig.json

• error TS2345: Argument of type 'Element | ChildNode' is not assignable to parameter of type 'string | Node'.
  • source/helpers/dom-utils.ts#L48
  • source/helpers/dom-utils.ts#L53

Redocly/redoc

tsconfig.json

• error TS2801: This condition will always return true since this 'Promise<any>' is always defined.
  • src/services/models/Example.ts#L40
• error TS2807: This syntax requires an imported helper named '__spreadArray' with 3 parameters, which is not compatible with the one in 'tslib'. Consider upgrading your version of 'tslib'.
  • src/utils/helpers.ts#L108

tsconfig.lib.json

• error TS2801: This condition will always return true since this 'Promise<any>' is always defined.
  • src/services/models/Example.ts#L40
• error TS2807: This syntax requires an imported helper named '__spreadArray' with 3 parameters, which is not compatible with the one in 'tslib'. Consider upgrading your version of 'tslib'.
  • src/utils/helpers.ts#L108

flatpickr/flatpickr

src/tsconfig.json

• error TS2571: Object is of type 'unknown'.
  • src/index.ts#L513
• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • src/index.ts#L514
• error TS2551: Property 'msMaxTouchPoints' does not exist on type 'Navigator'. Did you mean 'maxTouchPoints'?
  • src/index.ts#L2284

tsconfig.esm.json

• error TS2571: Object is of type 'unknown'.
  • src/index.ts#L513
• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • src/index.ts#L514
• error TS2551: Property 'msMaxTouchPoints' does not exist on type 'Navigator'. Did you mean 'maxTouchPoints'?
  • src/index.ts#L2284

tsconfig.json

• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string | Error'.
  • build.ts#L51
  • build.ts#L66
  • build.ts#L81
  • build.ts#L129
  • build.ts#L159
  • build.ts#L180
• error TS2571: Object is of type 'unknown'.
  • build.ts#L52
  • src/index.ts#L513
• error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
  • src/index.ts#L514
• error TS2551: Property 'msMaxTouchPoints' does not exist on type 'Navigator'. Did you mean 'maxTouchPoints'?
  • src/index.ts#L2284

[RyanCavanaugh]

@rbuckton specifically the issuance of error TS1436: Decorators must precede the name and all keywords of property declarations when a decorated member follows a non-semicolon-terminated property declaration

class C {
  foo

  @bar()
  baz;
}

[a-tarasyuk]

@RyanCavanaugh It seems duplicate of #45157 (#45165)

[RyanCavanaugh]

@a-tarasyuk lovely, thanks