Skip to content

Add a react monorepo to the perf suite #44251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amcasey opened this issue May 25, 2021 · 2 comments
Closed

Add a react monorepo to the perf suite #44251

amcasey opened this issue May 25, 2021 · 2 comments
Assignees
@armanio123
Labels
Domain: Performance Reports of unusually slow behavior Infrastructure Issue relates to TypeScript team infrastructure Rescheduled This issue was previously scheduled to an earlier milestone
Milestone
TypeScript 4.5.0

Comments

@amcasey
Copy link
Member

amcasey commented May 25, 2021

We currently have poor coverage of both react and project references. Adding a react monorepo would help.

Nominees:

  1. https://github.com/davidkpiano/xstate
    a) Easy build (install packages with yarn, tsc -b tsconfig.monorepo.json)
    b) Already on 4.2.4
    c) Responsive maintainers (I've worked with them before)
  2. https://github.com/tinymce/tinymce
    a) Much bigger than xstate
    b) Uses (many) path mappings
    c) Already on 4.2.4
    d) Slightly non-trivial build (need to prebuild icons or get errors about missing types)
@amcasey
Copy link
Member Author

amcasey commented May 25, 2021

FYI @rbuckton @DanielRosenwasser

@DanielRosenwasser DanielRosenwasser added the Infrastructure Issue relates to TypeScript team infrastructure label May 25, 2021
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.4.0 milestone May 25, 2021
@DanielRosenwasser DanielRosenwasser added the Domain: Performance Reports of unusually slow behavior label May 25, 2021
@amcasey amcasey mentioned this issue Aug 2, 2021
Closed
@andrewbranch andrewbranch added the Rescheduled This issue was previously scheduled to an earlier milestone label Aug 30, 2021
@sandersn
Copy link
Member

This is now merged into the RWC repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armanio123 armanio123

Labels
Domain: Performance Reports of unusually slow behavior Infrastructure Issue relates to TypeScript team infrastructure Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Milestone
TypeScript 4.5.0
Development

No branches or pull requests
5 participants
@sandersn @DanielRosenwasser @andrewbranch @amcasey @armanio123