Skip to content

Print a warning if using 'ts.factory' in a transformer #43423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rbuckton opened this issue Mar 29, 2021 · 0 comments
Open

Print a warning if using 'ts.factory' in a transformer #43423

rbuckton opened this issue Mar 29, 2021 · 0 comments
Labels
Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript
Milestone
Backlog

Comments

@rbuckton
Copy link
Contributor

Noted in #43407 (comment), we should discourage the use of ts.factory from within a transformer, as the transformer should instead use the factory provided to its context argument.
@rbuckton rbuckton self-assigned this Mar 29, 2021
@sandersn sandersn added the Suggestion An idea for TypeScript label Jul 1, 2021
@sandersn sandersn added this to the Backlog milestone Jul 1, 2021
@RyanCavanaugh RyanCavanaugh added the Experience Enhancement Noncontroversial enhancements label Feb 11, 2022
@DanielRosenwasser DanielRosenwasser mentioned this issue Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@sandersn @rbuckton @RyanCavanaugh