'infer function return type' refactoring always shown

[mjbvz]

Bug Report

🔎 Search Terms

• refactoring
• quick fix
• code action

🕗 Version & Regression Information

4.2.2

💻 Code

function foo() {
    return 1;
}

1. In VS Code, place cursor anywhere inside of foo

🙁 Actual behavior

The lightbulb always shows up. This is because the infer function return type quick fix is always being returned

🙂 Expected behavior

This quick fix should likely only show when refactoring are explicitly requested or if the cursor is at a specific spot in the code (such as the function signature)

/cc @jessetrinity

[mjbvz]

I have a feeling the ever present lightbulb is going to spawn a lot of issues when the next VS Code release goes out so I'm going to add a workaround on the VS Code side

[jessetrinity]

Is this fixed by #42737?

[mjbvz]

Yep looks like the same issue. I've checked in a workaround on the VS Code side

[jwbth]

Oh that's why I didn't see the item for "Infer function return type" in the autocomplete menu...

Good thing I though of searching the source.