"Infer function return type" is annoyingly suggested in function bodies

[DanielRosenwasser]

function foo() {
    let x = 123;
    return x;
}

If your cursor is anywhere in the body of this function, you will get a code action to "Infer function return type".

This is annoying because it always provides a lightbulb in the editor

and that is doubly-annoying in cases where you think you have a quick fix but it ends up being the same useless code action.

I'm not exactly sure what the right way is to surface this refactoring in a way that's not intrusive. Maybe by only providing it on return statements and the function signature itself? Thoughts @jessetrinity @sandersn?

[jessetrinity]

@DanielRosenwasser return statement and signature sound like the right places.

[sandersn]

I agree -- and I'm not even sure about return statements.

[a-tarasyuk]

and I'm not even sure about return statements.

I'm also not sure about return statements...

[jessetrinity]

Why not return statements? 😕

[sandersn]

The new code will be inserted on the function declaration, which can be far away from the return statement. Not a big deal, but it makes more sense for me to see a light bulb near to where the new code will be inserted.