Skip to content

document.createElement always marked deprecated #39212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Jun 23, 2020 · 4 comments · Fixed by #39323
Closed

document.createElement always marked deprecated #39212

mjbvz opened this issue Jun 23, 2020 · 4 comments · Fixed by #39323
Labels
Bug A bug in TypeScript

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 23, 2020

TypeScript Version: 4.0.0-dev-20200622

Search Terms:

  • deprecated

Code
For the JS

document.createElement('a');

Bug:

createElement is always rendered as deprecated

Screen Shot 2020-06-23 at 1 42 05 PM

I believe this is because one of the createElement overloads is deprecated

/cc @Kingwl @DanielRosenwasser We will need to fix this before we can ship @deprecated support in the stable version of VS Code

@mjbvz
Copy link
Contributor Author

mjbvz commented Jun 23, 2020

Ideally we should determine when a deprecated overload is being called. If that is not possible right now, I think we should be conservative and only mark a call deprecated if all of its overloads are deprecated

@Kingwl
Copy link
Contributor

Kingwl commented Jun 24, 2020

Okay, I'll take a look soon.

@jrieken
Copy link
Member

jrieken commented Jul 16, 2020

Using 4.0.0-dev20200708 I see deprecation warnings as below. Not sure if this isn't the latest release (tho using ms-vscode.vscode-typescript-next) or if this is the same as the createElement-issue.

Screenshot 2020-07-16 at 14 24 44

(same with 20200712)

@Kingwl
Copy link
Contributor

Kingwl commented Jul 16, 2020

Using 4.0.0-dev20200708 I see deprecation warnings as below. Not sure if this isn't the latest release (tho using ms-vscode.vscode-typescript-next) or if this is the same as the createElement-issue.

Screenshot 2020-07-16 at 14 24 44

(same with 20200712)

It's already fixed in nightly build yesterday(utc+8, or today)
You can see #39590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript
Projects
None yet
4 participants