Skip to content

performanceData.updateGraphDurationMs missing from protocol.d.ts #36589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Feb 3, 2020 · 3 comments · Fixed by #36595
Closed

performanceData.updateGraphDurationMs missing from protocol.d.ts #36589

mjbvz opened this issue Feb 3, 2020 · 3 comments · Fixed by #36595

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 3, 2020 •
edited
Loading

TypeScript Version: 3.8.0-dev.20200201

Search Terms:

  • tsserver
  • protocol.d.ts

Bug
Looks like performanceData.updateGraphDurationMs is currently missing from the server protocol definitions (protocol.d.ts)

Related issues
#35675

/cc @amcasey
@amcasey
Copy link
Member

amcasey commented Feb 4, 2020

Not fixed by #36210?

@amcasey
Copy link
Member

amcasey commented Feb 4, 2020

Looks like it's internal. I think I/we did that because it didn't seem to be of general interest, but I don't know our usual convention for such things. I guess I'll make a PR promoting it to public and see what people think.

@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 4, 2020

Sounds good. Right now VS Code has to define this property. Better if it can come from the TS server definitions even if VS Code and VS are the only consumers of it

@amcasey amcasey mentioned this issue Feb 4, 2020
Merged
@amcasey amcasey mentioned this issue Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Should Response.performanceData be public? amcasey/TypeScript
2 participants
@amcasey @mjbvz