Skip to content

Compile errors for VS Code codebase with TS 3.4 #30419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Mar 15, 2019 · 1 comment
Closed

Compile errors for VS Code codebase with TS 3.4 #30419

mjbvz opened this issue Mar 15, 2019 · 1 comment
Labels
Discussion Issues which may not have code impact

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 15, 2019 •
edited
Loading

TypeScript Version: 3.4.0-dev.20190311

Issue
After updating to build VS Code with TS 3.4, I ran into a handful of problems that had to be worked around. Here's the change that added the workarounds.

To repo original issues:

  1. In VS Code project
  2. git checkout 50ee8c5fa50f5ba85a130975e41a43dc06f554a0~1
  3. Build VS Code using 3.4.0-dev.20190311: tsc -p src/tsconfig.json --watch

I have not been able to create more minimal repos yet
@DanielRosenwasser DanielRosenwasser mentioned this issue Mar 22, 2019
Closed
@RyanCavanaugh RyanCavanaugh added the Discussion Issues which may not have code impact label Mar 25, 2019
@RyanCavanaugh
Copy link
Member

I've tracked these all down to root causes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Issues which may not have code impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RyanCavanaugh @mjbvz