Skip to content

Missing semi-colon in the extendsHelper #27312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spratmannc opened this issue Sep 24, 2018 · 4 comments
Closed

Missing semi-colon in the extendsHelper #27312

spratmannc opened this issue Sep 24, 2018 · 4 comments
Labels
Bug A bug in TypeScript Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone

Comments

@spratmannc
Copy link
Contributor

The missing semi-colon after the declaration of the extendStatics variable/function (es2015.ts, line 4082) results in linting errors (JSHint). For projects that contain both TypeScript and JavaScript source files, this presents a problem in CI builds, as its not always feasible to bypass semi-colon terminator requirements when linting the project.

It looks like this is just an oversight, since semi-colons are used consistently elsewhere.

This would not show up as a build error since the helper is specified as a string of text.

Expected behavior:
The extendsHelper helper should include a semi-colon after declaring the extendsStatic variable.

Actual behavior:
The semi-colon is missing.

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Sep 24, 2018
@RyanCavanaugh RyanCavanaugh added this to the Community milestone Sep 24, 2018
@spratmannc
Copy link
Contributor Author

#27313 Should address this.

@PaulIvanov
Copy link

does this issue need to be closed?

@spratmannc
Copy link
Contributor Author

No. I'm still waiting on pull request #27313 to be reviewed. Do I need to do something special to get it looked at?

@spratmannc
Copy link
Contributor Author

PR was completed. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

3 participants