Skip to content

Import fix for export = #25135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Jun 21, 2018 · 0 comments
Closed

Import fix for export = #25135

ghost opened this issue Jun 21, 2018 · 0 comments
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue

Comments

@ghost
Copy link

ghost commented Jun 21, 2018

TypeScript Version: 3.0.0-dev.20180621

Code

/// <reference path="fourslash.ts" />

// @Filename: /a.d.ts
////declare function a(): void;
////export = a;

// @Filename: /b.ts
////a;

goTo.file("/b.ts");
verify.importFixAtPosition(["?"]);

Expected behavior:

Get an import fix.

Actual behavior:

No fix. getAllReExportingModules doesn't handle this case.

@ghost ghost added Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. labels Jun 21, 2018
@mhegazy mhegazy assigned ghost Jun 21, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 21, 2018
@mhegazy mhegazy modified the milestones: TypeScript 3.0, TypeScript 3.1 Jul 2, 2018
@ghost ghost added the Fixed A PR has been merged for this issue label Jul 17, 2018
@ghost ghost closed this as completed in #25708 Aug 28, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

1 participant