Skip to content

Use a strong hash (SHA256) when transmitting VS Code project identifiers in telemetry #24046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amcasey opened this issue May 10, 2018 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@amcasey
Copy link
Member

amcasey commented May 10, 2018

The projectid property on event typescript/projectinfo has been suppressed because it contains weakly-hashed (MD5) customer content (a file path). If we want to regain this functionality (project identification), we will need to introduce a new property (because we have to continue to suppress telemetry from old clients) containing a strongly-hashed (SHA256) value.

Note that the actual code change might be in https://github.com/Microsoft/vscode, since that's where our extension lives.

@amcasey
Copy link
Member Author

amcasey commented May 10, 2018

When this is done, we'll also have to add a GDPR classification for the new property before we can start consuming it.

@mhegazy mhegazy added the Bug A bug in TypeScript label May 10, 2018
@mhegazy mhegazy assigned ghost May 10, 2018
@mhegazy mhegazy added this to the TypeScript 2.9.1 milestone May 10, 2018
@ghost ghost added the Fixed A PR has been merged for this issue label May 14, 2018
@ghost ghost closed this as completed in #24099 May 14, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants