Skip to content

Add explicit quote character format option #21768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Feb 8, 2018 · 4 comments
Closed

Add explicit quote character format option #21768

mjbvz opened this issue Feb 8, 2018 · 4 comments
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 8, 2018

Search Terms:

  • Quote
  • Format
  • Import
  • Quick fix

Problem
There are now number of cases where TS generates code with quote characters:

  • Imports
  • Bracket completions
  • Implement interface / abstract class

A recurring request against VS code is to make the quote type explicitly configurable, such as: always use double quotes or always use single quotes.

Proposal
Add a new format or configuration options for quote characters. This new setting would only apply to code generated by typescript. We would not change existing quotes in code

Related Issues:

@mhegazy
Copy link
Contributor

mhegazy commented Feb 8, 2018

I think this is a duplicate of #20619

@mhegazy mhegazy added the Duplicate An existing issue was already created label Feb 8, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 8, 2018

Yes. I'm just raising this one on its own because I see it repeated so often. In addition to #20619, can we please keep an issue open that specifically tracks configuring quotes

@mhegazy
Copy link
Contributor

mhegazy commented Feb 8, 2018

Can we just use #20619? we are planning on taking that one on this release..

@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 8, 2018

Ok, glad to see this is scheduled for 2.8. I'll add a comment in #20619 there that makes it clear that configuring quotes is part of the feature

@mjbvz mjbvz closed this as completed Feb 8, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants