Skip to content

Node interface is missing the contains() method #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sccolbert opened this issue Nov 24, 2014 · 2 comments
Closed

Node interface is missing the contains() method #1253

sccolbert opened this issue Nov 24, 2014 · 2 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.8

Comments

@sccolbert
Copy link

The contains() method is defined for a Node:
https://developer.mozilla.org/en-US/docs/Web/API/Node.contains

TypeScript has it defined on HTMLElement:
https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L272
@danquirk danquirk added Bug A bug in TypeScript Revisit An issue worth coming back to labels Nov 24, 2014
@mhegazy mhegazy added this to the TypeScript 2.0 milestone Dec 3, 2014
@mhegazy mhegazy added the Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript label Dec 3, 2014
@mhegazy mhegazy self-assigned this Dec 3, 2014
@mhegazy mhegazy modified the milestones: TypeScript 2.0, TypeScript 1.6 Apr 2, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.6, TypeScript 1.7 Jul 1, 2015
@mhegazy mhegazy modified the milestones: TypeScript 2.0, TypeScript 1.7 Oct 6, 2015
@mhegazy mhegazy assigned zhengbli and unassigned mhegazy Oct 6, 2015
@zhengbli zhengbli mentioned this issue Oct 29, 2015
Merged
@zhengbli zhengbli reopened this Nov 6, 2015
@sccolbert
Copy link
Author

@zhengbli I added a comment to that PR. I don't think the issue is fully solved.

@zhengbli zhengbli mentioned this issue Nov 10, 2015
Merged
@mhegazy mhegazy removed the Revisit An issue worth coming back to label Nov 11, 2015
@zhengbli zhengbli reopened this Nov 11, 2015
@sccolbert
Copy link
Author

👍

@zhengbli zhengbli mentioned this issue Nov 30, 2015
Merged
@zhengbli zhengbli added Fixed A PR has been merged for this issue and removed Fixed in TSJS repo labels Dec 1, 2015
@zhengbli zhengbli closed this as completed Dec 1, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.8
Development

No branches or pull requests
4 participants
@sccolbert @zhengbli @danquirk @mhegazy