Skip to content

Go to Symbol should position text cursor on name of target #12000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waderyan opened this issue Nov 2, 2016 · 3 comments
Closed

Go to Symbol should position text cursor on name of target #12000

waderyan opened this issue Nov 2, 2016 · 3 comments
Assignees

Comments

@waderyan
Copy link

waderyan commented Nov 2, 2016

From @chrmarti on October 31, 2016 14:48

  • VSCode Version: Code - Insiders 1.7.0-insider (0706b42, 2016-10-28T13:00:19.188Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.3
vscode-docker PeterJausovec 0.0.6
regex chrmarti 0.0.6
vscode-eslint dbaeumer 1.0.7
ghlink dt 0.0.4
gitlens eamodio 0.5.5
tslint eg2 0.5.39
PowerShell ms-vscode 0.7.2
csharp ms-vscode 1.4.1
debugger-for-chrome msjsdiag 2.1.0
diff rafaelmaiolla 0.0.1
kustovscode seanmcbreen 0.0.1
vscode-open-in-github sysoev 1.2.0

Steps to Reproduce:

  1. Go to Symbol that's a class or a class member (possibly others)
  2. The text cursor is positioned on the first modifier before the name

This breaks the flow of keyboard navigation for actions like Find All References, Rename Symbol, etc., because the user now has to navigate the cursor to the symbol's name first.

Copied from original issue: microsoft/vscode#14759

@waderyan waderyan self-assigned this Nov 2, 2016
@waderyan
Copy link
Author

waderyan commented Nov 2, 2016

From @rebornix on October 31, 2016 17:8

I found it share the same experience with Go To Definition.

@waderyan
Copy link
Author

waderyan commented Nov 2, 2016

From @dbaeumer on November 1, 2016 15:11

We simply use the position we get from the tsserver. So need to check what they return (using tracing option)

@waderyan
Copy link
Author

waderyan commented Nov 2, 2016

Apologize this was migrated too quickly...

@waderyan waderyan closed this as completed Nov 2, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant