Skip to content

Formatting jsx file adds and removes meaningful spaces #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waderyan opened this issue Sep 20, 2016 · 4 comments
Closed

Formatting jsx file adds and removes meaningful spaces #11010

waderyan opened this issue Sep 20, 2016 · 4 comments
Labels
Duplicate An existing issue was already created VS Code Tracked There is a VS Code equivalent to this issue

Comments

@waderyan
Copy link

From @anvish on September 15, 2016 16:51

  • VSCode Version: 1.5.2
  • OS Version: Windows 7 SP1

Steps to Reproduce:

  1. Open .jsx file
import React from 'react'
class Sample extends React.Component {
    render() {
        return (
            <div>
                <div>Joe&apos;s Text</div>
                <div>Joe. Text.</div>
            </div>
        )
    }
}
export default Sample
  1. Run formatting

Joe&apos;s Text changes to Joe&apos; s Text (space is added),
Joe. Text. changes to Joe.Text. (space is removed)

Copied from original issue: microsoft/vscode#12092

@waderyan
Copy link
Author

From @bpasero on September 16, 2016 3:48

Reading your description it seems that the issue originates from an extension and not VS Code itself. Thereby I will close this issue and kindly ask you to report this issue against the extension repository.

Most extensions are on GitHub as well so it should be easy to file it against the extension. If you open an extension on the market place, click on the Support link to find out more.

screen shot 2016-05-05 at 12 51 17

Thanks again for your feedback!

@waderyan
Copy link
Author

@bpasero can you comment on the reopen? I don't believe this is an extension issue. It seems likely to be a language service issue. I'll migrate to them, once I hear from you.

@waderyan waderyan self-assigned this Sep 20, 2016
@waderyan
Copy link
Author

From @bpasero on September 17, 2016 4:13

@waderyan yes I think so too that is why I reopened it 👍

@waderyan waderyan added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 20, 2016
@waderyan waderyan removed their assignment Sep 20, 2016
@RyanCavanaugh
Copy link
Member

Duplicate #8817

@RyanCavanaugh RyanCavanaugh added Duplicate An existing issue was already created VS Code Tracked There is a VS Code equivalent to this issue and removed VS Code Tracked There is a VS Code equivalent to this issue labels Sep 20, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

2 participants