Correct outline hint spans for functions

amcasey · amcasey · commit fdacf7f87a8b · 2019-06-11T18:00:03.000-07:00
diff --git a/src/services/outliningElementsCollector.ts b/src/services/outliningElementsCollector.ts
@@ -237,7 +237,7 @@ namespace ts.OutliningElementsCollector {
             ? findChildOfKind(node, SyntaxKind.OpenParenToken, sourceFile)
             : findChildOfKind(body, SyntaxKind.OpenBraceToken, sourceFile);
         const closeToken = findChildOfKind(body, SyntaxKind.CloseBraceToken, sourceFile);
-        return openToken && closeToken && spanBetweenTokens(openToken, closeToken, node.parent, sourceFile, /*autoCollapse*/ node.parent.kind !== SyntaxKind.ArrowFunction);
+        return openToken && closeToken && spanBetweenTokens(openToken, closeToken, node, sourceFile, /*autoCollapse*/ node.kind !== SyntaxKind.ArrowFunction);
     }
 
     function spanBetweenTokens(openToken: Node, closeToken: Node, hintSpanNode: Node, sourceFile: SourceFile, autoCollapse = false, useFullStart = true): OutliningSpan {

Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ namespace ts.OutliningElementsCollector {`
`237`	`237`	`? findChildOfKind(node, SyntaxKind.OpenParenToken, sourceFile)`
`238`	`238`	`: findChildOfKind(body, SyntaxKind.OpenBraceToken, sourceFile);`
`239`	`239`	`const closeToken = findChildOfKind(body, SyntaxKind.CloseBraceToken, sourceFile);`
`240`		`- return openToken && closeToken && spanBetweenTokens(openToken, closeToken, node.parent, sourceFile, /autoCollapse/ node.parent.kind !== SyntaxKind.ArrowFunction);`
	`240`	`+ return openToken && closeToken && spanBetweenTokens(openToken, closeToken, node, sourceFile, /autoCollapse/ node.kind !== SyntaxKind.ArrowFunction);`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`function spanBetweenTokens(openToken: Node, closeToken: Node, hintSpanNode: Node, sourceFile: SourceFile, autoCollapse = false, useFullStart = true): OutliningSpan {`