Skip to content

Commit ea41813

Browse files
committed
Add PR feedback
1 parent 4c1f9cb commit ea41813

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/compiler/checker.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23263,7 +23263,9 @@ namespace ts {
2326323263

2326423264
function checkExportSpecifier(node: ExportSpecifier) {
2326523265
checkAliasSymbol(node);
23266-
collectLinkedAliases(node.propertyName || node.name, /*setVisibility*/ true); // Collect linked aliases to set visibility links
23266+
if (compilerOptions.declaration) {
23267+
collectLinkedAliases(node.propertyName || node.name, /*setVisibility*/ true); // Collect linked aliases to set visibility links
23268+
}
2326723269
if (!(<ExportDeclaration>node.parent.parent).moduleSpecifier) {
2326823270
const exportedName = node.propertyName || node.name;
2326923271
// find immediate value referenced by exported name (SymbolFlags.Alias is set so we don't chase down aliases)
@@ -23301,7 +23303,10 @@ namespace ts {
2330123303
}
2330223304
if (node.expression.kind === SyntaxKind.Identifier) {
2330323305
markExportAsReferenced(node);
23304-
collectLinkedAliases(node.expression as Identifier, /*setVisibility*/ true); // Sets visibility flags on refernced nodes
23306+
23307+
if (compilerOptions.declaration) {
23308+
collectLinkedAliases(node.expression as Identifier, /*setVisibility*/ true); // Sets visibility flags on refernced nodes
23309+
}
2330523310
}
2330623311
else {
2330723312
checkExpressionCached(node.expression);

src/compiler/declarationEmitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1250,7 +1250,7 @@ namespace ts {
12501250
}
12511251

12521252
function bindingNameContainsVisibleBindingElement(node: BindingName): boolean {
1253-
return !!node && isBindingPattern(node) && some(node.elements, elem => !isOmittedExpression(elem) && (resolver.isDeclarationVisible(elem) || bindingNameContainsVisibleBindingElement(elem.name)));
1253+
return !!node && isBindingPattern(node) && some(node.elements, elem => !isOmittedExpression(elem) && isVariableDeclarationVisible(elem));
12541254
}
12551255

12561256
function isVariableDeclarationVisible(node: VariableDeclaration | BindingElement) {

0 commit comments

Comments
 (0)